summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-08-22 11:07:07 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-08-22 11:07:07 +0200
commit27b07b447be9cf960d1a44e480d8356245481d17 (patch)
tree812e343dd40dabf59397da9cc7b4ba621a6b6a8d
parent28dc226a31fa0cc72432f5607ab5cd74503ef43d (diff)
downloadcolitur-27b07b447be9cf960d1a44e480d8356245481d17.tar.gz
colitur-27b07b447be9cf960d1a44e480d8356245481d17.zip
docs(ef): retract the false LMS Ordo witness claim for Mass_formulary.Votive
Fix round 1's own comment claimed the Latin Mass Society Ordo witnesses the Votive tag directly, reading its "V Mass of BVM" as an abbreviation for "votive". That was wrong: the Ordo's I-V are roman numerals naming WHICH of the Missal's five seasonal "Missae de sancta Maria in sabbato" (RG 309(a)'s own "iuxta temporum diversitatem") is said on a given Saturday, not a marker of the Mass's kind. All five numerals occur through the Ordo (I x1, II x4, III x3, IV x3, V x8); the false reading came from "V Mass of BVM" also being a substring of "IV Mass of BVM". Votive itself is unaffected and stays correct on RG 431(e) alone, quoted verbatim in its place: "e) in Missis votivis IV classis de Angelis, quocumque die, et de B. Maria Virg. quae in sabbato celebrantur" -- votive Masses of the IV class, of the BVM, celebrated on Saturday. The retraction is recorded, not softened, in lectionary_ef.ml/.mli and the test pin's own comment, together with what the Ordo's numeral actually means so the mistake is not repeated, and the consequence it leaves behind: because the numeral names WHICH seasonal Mass is said, a future comparison against the Ordo (Task 6) can validate bvm_saturday_citations' own season-keyed selection, not merely that some BVM Mass was chosen. Comments and docs only -- no behaviour change. Both suites re-run green and colitur day re-confirmed byte-identical.
-rw-r--r--lib/rites/rite_ef/lectionary_ef.ml45
-rw-r--r--lib/rites/rite_ef/lectionary_ef.mli25
-rw-r--r--test/test_lectionary_ef.ml14
3 files changed, 61 insertions, 23 deletions
diff --git a/lib/rites/rite_ef/lectionary_ef.ml b/lib/rites/rite_ef/lectionary_ef.ml
index 13ff5d5..1fba3de 100644
--- a/lib/rites/rite_ef/lectionary_ef.ml
+++ b/lib/rites/rite_ef/lectionary_ef.ml
@@ -371,18 +371,41 @@ let readings ~lectionary ~commons ~observed ~temporal ~date ~temporal_at =
round 1, coordinator review -- the first pass tagged this
[Own_slug] for lack of a better constructor and flagged it as a
judgement call; [Mass_formulary.source] has grown a [Votive]
- case since, precisely for this branch). RG 309(a) (this
- branch's own header comment above) and RG 431(e) ("in Missis
- votivis IV classis ... de B. Maria Virg. quae in sabbato
- celebrantur", temporal_ef.ml's own colour-chain comment quotes
- it in full) both classify this Mass itself, in the Missal's own
- words, as a "Missa votiva" -- a votive Mass said IN PLACE of the
+ case since, precisely for this branch). RG 431(e)
+ (docs/research/LT.txt, verbatim): "e) in Missis votivis IV
+ classis de Angelis, quocumque die, et de B. Maria Virg. quae in
+ sabbato celebrantur" -- votive Masses of the IV class, of the
+ Angels on any day, and of the BVM WHICH ARE CELEBRATED ON
+ SATURDAY: the Missal's own words classify this exact Mass as a
+ "Missa votiva", not as the day's own office's Mass, corroborated
+ by RG 309(a) (this branch's own header comment above, "iuxta
+ temporum diversitatem") naming the FIVE seasonal Masses RG 431(e)
+ is speaking of. Together: a votive Mass said IN PLACE of the
day's own office's Mass, the office (RG 78, Officium sanctae
- Mariae in sabbato) being kept unchanged. WITNESSED, not merely
- argued: the Latin Mass Society Ordo (docs/research/ordo/lms-
- ordo-2024-2025.pdf) prints this exact day as "OUR LADY on
- SATURDAY IV Cl W / V Mass of BVM" -- "V" is that Ordo's own
- abbreviation for Votive.
+ Mariae in sabbato) being kept unchanged.
+
+ CORRECTED, fix round 2 (coordinator review): fix round 1's own
+ comment here claimed the Latin Mass Society Ordo witnesses
+ [Votive] directly, printing "V Mass of BVM" with "V" read as an
+ abbreviation for "votive". That was the coordinator's
+ misreading, not this codebase's, and it was wrong: the Ordo's
+ "I"-"V" are ROMAN NUMERALS naming WHICH of the Missal's five
+ seasonal "Missae de sancta Maria in sabbato" (this branch's own
+ header comment; RG 309(a)'s "iuxta temporum diversitatem") is
+ said on a given Saturday -- not an abbreviation of anything, and
+ not a marker of the Mass's class or kind. All five numerals
+ occur through the Ordo (I x1, II x4, III x3, IV x3, V x8,
+ counted across the whole document); "V Mass of BVM" merely also
+ happens to be substring-matched by a naive search for "V Mass of
+ BVM" inside "IV Mass of BVM", which is what produced the
+ original false reading. [Votive] itself is UNAFFECTED by this
+ correction and stays right, on RG 431(e) alone -- only the
+ Ordo-witness claim is retracted, not softened, removed. A
+ genuinely useful consequence survives the mistake: because the
+ Ordo's own numeral names WHICH seasonal Mass is said, a future
+ comparison against it (Task 6 of this plan) can validate
+ [bvm_saturday_citations]'s own season-keyed SELECTION, not
+ merely that some BVM Mass was chosen.
[said] is UNCHANGED by this correction and stays the day's own
temporal slug: [is_bvm_saturday_office] only ever fires when
diff --git a/lib/rites/rite_ef/lectionary_ef.mli b/lib/rites/rite_ef/lectionary_ef.mli
index 43763ff..0797c0d 100644
--- a/lib/rites/rite_ef/lectionary_ef.mli
+++ b/lib/rites/rite_ef/lectionary_ef.mli
@@ -111,14 +111,23 @@ val commons_for : commons:Commons.t -> Slug.t -> (Slug.t * Citation.t list) opti
309(a) Saturday votive Mass of Our Lady also answers here (structurally,
not as a fifth numbered step), but is tagged
{!Colitur_kernel.Mass_formulary.Votive} instead, not [Own_slug]: RG
- 309(a)/431(e) classify it, in the Missal's own words, as a "Missa
- votiva" said IN PLACE of the day's own office's Mass, the office (RG
- 78) itself being kept -- witnessed by the Latin Mass Society Ordo,
- which prints this day's Mass as "V" (Votive). [said] is still that
- slug: only the source constructor differs from an ordinary Step 2
- lookup, because the guard that reaches this branch only ever fires
- when the observed celebration already IS the day's own temporal
- office -- see the implementation comment on that branch.
+ 431(e) ("in Missis votivis IV classis ... de B. Maria Virg. quae in
+ sabbato celebrantur", docs/research/LT.txt) classifies it, in the
+ Missal's own words, as a "Missa votiva" said IN PLACE of the day's own
+ office's Mass, the office (RG 78) itself being kept, corroborated by RG
+ 309(a)'s own "iuxta temporum diversitatem" naming the five seasonal
+ Masses RG 431(e) speaks of. (CORRECTED, fix round 2: this previously
+ also cited the Latin Mass Society Ordo as witnessing the tag directly,
+ reading its "V Mass of BVM" as an abbreviation for "votive" -- the
+ coordinator's own misreading. The Ordo's "I"-"V" are ROMAN NUMERALS
+ naming which of the five seasonal Masses is said, not a marker of the
+ Mass's kind; see the implementation comment on this branch for the
+ full account and the validation use this correction still leaves
+ available for Task 6.) [said] is still that slug: only the source
+ constructor differs from an ordinary Step 2 lookup, because the guard
+ that reaches this branch only ever fires when the observed celebration
+ already IS the day's own temporal office -- see the implementation
+ comment on that branch.
- {b Step 3} -- for a weekday whose own slug has no entry, the preceding
Sunday's temporal slug (never its observed one; a Sunday is guarded
out because it has no PRECEDING Sunday to resume, not because
diff --git a/test/test_lectionary_ef.ml b/test/test_lectionary_ef.ml
index 5bdce12..04076c7 100644
--- a/test/test_lectionary_ef.ml
+++ b/test/test_lectionary_ef.ml
@@ -610,10 +610,16 @@ let formulary_cases =
(* Fix round 1 (coordinator review): the RG 309(a)/RG 78 Saturday votive
Mass of Our Lady, structurally reached between steps 4 and 2 (see
[readings]' own implementation comment) but tagged [Votive], not
- [Own_slug] -- the Missal's own RG 309(a)/431(e) classify this Mass as
- a "Missa votiva", said in place of the day's own office's Mass while
- the office (RG 78) itself is kept; witnessed by the Latin Mass
- Society Ordo, which prints this day's Mass as "V" (Votive). 1 August
+ [Own_slug] -- RG 431(e) ("in Missis votivis IV classis ... de B.
+ Maria Virg. quae in sabbato celebrantur") classifies this Mass, in
+ the Missal's own words, as a "Missa votiva", said in place of the
+ day's own office's Mass while the office (RG 78) itself is kept.
+ (CORRECTED, fix round 2: this previously also claimed the Latin Mass
+ Society Ordo witnesses the tag by printing "V" as an abbreviation for
+ "votive" on this day -- that was the coordinator's own misreading;
+ the Ordo's "I"-"V" are roman numerals naming which of the Missal's
+ five SEASONAL Masses is said, not the Mass's kind -- see
+ [readings]' own implementation comment for the full account.) 1 August
2026 verified directly against the real resolver (`colitur day
2026`), not trusted from a supplied date, given this session's own
drifted-pin history: a IV-class Saturday, "Officium sanctae Mariae in