summaryrefslogtreecommitdiff
path: root/data
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-08-17 17:22:43 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-08-17 17:22:43 +0200
commit2b9f8133a22ce6dc309644a98bbe61507f574b38 (patch)
treeedb24a59d092f56f00dcbca654224a0622725d5e /data
parentf2a0660a9b60b70af32f1157dc78cdfcb298c9f7 (diff)
downloadcolitur-2b9f8133a22ce6dc309644a98bbe61507f574b38.tar.gz
colitur-2b9f8133a22ce6dc309644a98bbe61507f574b38.zip
feat(kernel): movable Date_spec variants, and Rogation Wednesday
Date_spec carried one variant, Fixed(month, day), and its own header said Sunday- and Easter-relative forms would arrive with the OF sanctoral. They arrive early because two things needed them at once: a user-supplied overlay carrying a local movable feast had no way to express "the first Sunday of October", and Rogation Wednesday's commemoration has been recorded as architecturally blocked since 2026-08-13. That blockage turns out to have been a premise, not a fact. The register concluded the Rogation "is not Commemoration_only sanctoral data by nature... it needs a genuinely THIRD kind of thing this architecture has no name for" -- but the reasoning rested on there being "no civil (month, day) pair to anchor a Fixed entry to". That is a statement about Date_spec's expressiveness. With Easter_offset the entity is ordinary sanctoral data, the identical shape Add major-litanies already ships, differing only in how the date is written. No third channel was needed. The register is corrected rather than left contradicting the code. Two variants: Easter_offset of int, and Nth_weekday of {month; nth; weekday} with negative nth counting from the end. Fixed's sexp representation is untouched, so all 327 sanctoral entries and the whole overlay parse unchanged. Both are re-validated in t_of_sexp through their smart constructors, extending the idiom Fixed already used -- the failure that guards against is invisible, a spec deserialising into something that silently never resolves and a celebration vanishing with no diagnostic. Easter is supplied by the rite, not computed in the kernel. Computus ships Gregorian and Julian both, and picking one here would hard-code a Roman assumption into rite-agnostic code and be silently wrong for a Julian-reckoning rite. Rite.t gains an easter field; Rite_ef supplies the Gregorian one. Layer keeps a split index. Fixed entries stay in the year-independent (month, day) table, which preserves the fast path and the "30 November counted twice in a 371-day span" behaviour validate.mli documents for St Andrew. Movable entries have no year-independent key by construction -- the same spec lands on a different (month, day) each year -- so they resolve per civil year into a rata-die table. index_by_date is removed rather than kept as an alias: two ways to index a layer, one of which silently ignores movable entries, is the trap this change exists to avoid. Two domain-edge defects, both found by the suite rather than reasoning. A liturgical year is Advent-anchored, so resolving civil year y names y +/- 1, and at the edges those are 1582 and 10000, which Computus correctly refuses by raising. The ceiling surfaced through the domain-ceiling test, the floor through `colitur day 1583` failing outright. Fixed once, in Layer.index, the single point that calls the rite's easter -- a clamp repeated per caller would have been two places to get wrong a third time. Rogation Wednesday: RG 87 assigns the Litaniae minores to the Monday, Tuesday AND Wednesday before Ascension (scan1:691); colitur built the first two from the start and never the third. RG 88 keeps it out of the Office, so the Ascension Vigil remains observed. RG 89 routes it through the Major Litanies' rules, but RG 109's closed list names only maiores, so by RG 107 it is an ORDINARY commemoration -- confirmed in the output, not assumed. Name from the Missal's own "feria IV" (scan1:20495-20497), violet to match the Monday and Tuesday offices. Blast radius, full 1583-9999 sweep against the pre-change binary: 2257 days, every one the same shape, zero unclassified, line counts equal both sides. The complement is the informative half -- in the other 6160 years the Rogation does not appear at all, because RG 111 admits one commemoration on a II-class day and an impeded feast takes it under RG 113, a Commemoration_only candidate having no row in RG 91's table. Both shapes are pinned. Allow-lists unmoved: layer 3 compares no commemorations and is blind by construction, and layer 4's 2026-2027 window has a competing feast on both Wednesdays, so the Rogation is capped out in exactly the years the oracle can see. C8 is unchanged, asserted by its own count pin. Not built: Sunday-relative specs, which nothing needs yet, and the --overlay plumbing that would let a user actually supply a local movable feast. Nth_weekday therefore ships with synthetic and property coverage only; inventing a shipped entry to exercise it would be fabricating calendar data. Register: section 6.10.
Diffstat (limited to 'data')
-rw-r--r--data/ef/adjustments.sexp50
1 files changed, 50 insertions, 0 deletions
diff --git a/data/ef/adjustments.sexp b/data/ef/adjustments.sexp
index f41d0d1..790665b 100644
--- a/data/ef/adjustments.sexp
+++ b/data/ef/adjustments.sexp
@@ -257,6 +257,49 @@
; rewrite (bucket recomputation) and .superpowers/sdd/2026-08-12-colitur-
; rg16a/sanctoral-audit-report.md. Two shapes of finding follow.
;
+; `Add rogation-wednesday` -- NEW (movable-date-specs task, 2026-08-17).
+; RG 87, primary-verified: "Litaniae minores seu Rogationes, per se,
+; assignantur feriis II, III et IV ante festum Ascensionis Domini"
+; (scan1.txt:691) -- Monday, Tuesday AND WEDNESDAY. colitur's temporal cycle
+; already builds `ef-rogation-{monday,tuesday}` (Easter+36/+37) but never
+; Wednesday: Easter+38 is by construction the Ascension Vigil (RG 91 entry
+; 21), which wins the day structurally, so `Temporal_ef.named` emits the
+; Vigil and there was no channel for the Rogation observance at all.
+;
+; That gap was architectural, not an oversight, and it is THIS task that
+; closes it: until Date_spec grew `Easter_offset`, there was no (month, day)
+; pair a Fixed spec could anchor to, which is exactly why the register
+; concluded this "is not Commemoration_only sanctoral data by nature". With a
+; movable spec it plainly is -- the identical shape `Add major-litanies`
+; above already uses, differing only in how the date is expressed.
+;
+; RG 88: nothing is done in the Office, only the Mass -- so the Vigil's own
+; office identity is CORRECTLY untouched; this entry is a commemoration and
+; never competes for the observed slot (`Commemoration_only` -> band returns
+; `unclassified`, checked first, ahead of every rank-keyed branch).
+;
+; RG 89: "Ad processionem aut alias peculiares supplicationes et Missam aut
+; COMMEMORATIONEM quod attinet, serventur quae supra de Litaniis maioribus
+; statuta sunt (nn. 81-83 et 86)". Note what follows: RG 109's closed list of
+; privileged commemorations names only "de Litaniis MAIORIBUS" (f), never
+; minoribus, so by RG 107's closing rule this is an ORDINARY commemoration --
+; unlike the Major Litanies' privileged one. That asymmetry is deliberate and
+; is asserted in test_rite_ef.ml.
+;
+; Name: "feria IV Rogationum" is the Missal's own (scan1.txt:20495-20497,
+; "Et in minoribus ante Ascensionem: feria II Rogationum, statio ad S. Mariam
+; maiorem; feria III, statio ad S. Ioannem in Laterano; feria IV, statio ad
+; S. Petrum"). Colour violet, matching the Rogation Monday/Tuesday offices
+; `Temporal_ef` already builds.
+;
+; `subject Saint` matches `major-litanies` above. It is behaviourally INERT
+; here, verified rather than assumed: `band` returns `unclassified` for any
+; Commemoration_only candidate before reading subject at all, and the only
+; other readers are RG 112(a) (fires on `Lord` only) and RG 112(d)'s
+; `is_bvm_office` (`Bvm` only). `Temporal` would arguably describe both this
+; and the Major Litanies better; changing them is a separate, zero-blast-
+; radius tidy-up, deliberately not folded into this task.
+;
; `Add barbara` -- a genuine DATA GAP, the same shape as the ef-rebootstrap
; task's five (agnes-secundo/boniface-martyr/eusebius-confessor/evaristus/
; theodore, above): both scans, 4 December, carry a second line under S.
@@ -330,6 +373,13 @@
(rank Class4) (status Commemoration_only) (colour Violet)
(subject Saint) (citations ()) (layer ef-universal)))))
(Add
+ ((date (Easter_offset 38))
+ (cel
+ ((slug rogation-wednesday)
+ (names ((la "Feria IV Rogationum") (en "Rogation Wednesday")))
+ (rank Class4) (status Commemoration_only) (colour Violet)
+ (subject Saint) (citations ()) (layer ef-universal)))))
+ (Add
((date (Fixed (month 12) (day 4)))
(cel
((slug barbara)