summaryrefslogtreecommitdiff
path: root/test/test_golden.ml
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-08-13 17:09:27 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-08-13 17:09:27 +0200
commitdce208f57cfeeee0715cf35389d37e7ce98227ae (patch)
tree9870e58df161646d71c2f08e5de7f4eefda1434e /test/test_golden.ml
parentd5df5e79c731ac7f7f89969c0cafe564fdc6e8ab (diff)
downloadcolitur-dce208f57cfeeee0715cf35389d37e7ce98227ae.tar.gz
colitur-dce208f57cfeeee0715cf35389d37e7ce98227ae.zip
fix(ef): RG 112(d) excludes a same-BVM commemoration (fix round 1, F1)
The BVM Saturday Office is itself "de B. Maria Virg."; RG 112(d) (Caput XVI, "De Commemorationibus") excludes another commemoration whose own oration invokes the SAME BVM's intercession. our-lady-of-mt-carmel (16 July, Commemoration_only) was wrongly admitted as an ordinary commemoration alongside the Office on every 16-July-Saturday -- its own collect explicitly invokes "her" (eius) patronage, and both photographic scans print a rubric anticipating exactly this collision (an either/or of Mass texts, not a joint commemoration). Precedence_ef gains marian_slugs (a closed, hand-verified list of sanctoral slugs that are themselves feasts of the BVM) and is_bvm_office (true for subject = Bvm OR a marian_slugs member -- the disjunction is load-bearing: the Office is identified only by subject, since its own slug is deliberately reused from the ordinary ferial fallback; Mt Carmel is identified only by the list, since its own subject tag is Saint, not Bvm). disposition gains a new branch, checked before the pre-existing Commemoration_only catch-all, since the one live witness is Commemoration_only and that branch's own "always Commemorate" had no exception for this shape. Checked exhaustively against every Marian-named sanctoral entry: only Commemoration_only-status entries can ever reach this branch live (a Feast-status one always wins outright instead of losing). Of the two such entries in the data, only Mt Carmel is reachable -- our-lady-of-ransom (24 September) is provably unreachable: 24 September falling on a Saturday forces 1 September to a Thursday, which by construction makes 24 September the September Ember Saturday, Class2, every time, not a sampled coincidence. Re-measured against the full pre-change binary: the original 75,853-day blast radius is unchanged in total, splitting into 74,633 colour-only + 1,220 colour+comms (16-July Saturdays). Mutation-tested: exactly 3 new tests redden, nothing else.
Diffstat (limited to 'test/test_golden.ml')
-rw-r--r--test/test_golden.ml24
1 files changed, 23 insertions, 1 deletions
diff --git a/test/test_golden.ml b/test/test_golden.ml
index bb4bcfc..fdfc01d 100644
--- a/test/test_golden.ml
+++ b/test/test_golden.ml
@@ -940,6 +940,24 @@ let test_bvm_saturday_loses_to_most_holy_name_of_mary_2026 () =
colour=white subject=bvm name_la=- comms=[] in=- out=[]"
(describe d)
+(* RG112(d), fix round 1 (coordinator finding F1): PE.marian_slugs's own
+ citation (precedence_ef.ml) has the full RG112(d) argument, including
+ the 16 July "Missa dici potest aut ... aut ..." rubric found on both
+ photographic scans. 16 July 2033 is a real otherwise-unoccupied
+ Saturday; before this fix, [comms] here read
+ "[our-lady-of-mt-carmel:ordinary]" (confirmed against real pre-fix
+ `colitur day 2033` output). *)
+let test_bvm_saturday_excludes_mt_carmel_2033 () =
+ let d = fetch 2033 7 16 in
+ Alcotest.(check bool)
+ "2033-07-16: Mt Carmel is in [omitted] (RG112(d)), not silently dropped from the record" true
+ (omitted_has d "our-lady-of-mt-carmel");
+ Alcotest.(check string)
+ "2033-07-16: the BVM Saturday office observed, white; NO commemoration of Mt Carmel (RG112(d))"
+ "2033-07-16 saturday season=time-after-pentecost week=5 slug=ef-time-after-pentecost-5-saturday \
+ rank=class-4 colour=white subject=bvm name_la=Officium sanctae Mariae in sabbato comms=[] in=- out=[]"
+ (describe d)
+
let suite =
( "golden pins (known-tricky years)",
[ Alcotest.test_case "Easter extreme: 1598 earliest (22 Mar, Gauss-verified)" `Quick
@@ -1004,5 +1022,9 @@ let suite =
Alcotest.test_case
"RG91 e27/RG78/RG26: the BVM Saturday office loses to Most Holy Name of Mary (subject Bvm too) \
and is omitted, no confusion (2026-09-12)"
- `Quick test_bvm_saturday_loses_to_most_holy_name_of_mary_2026
+ `Quick test_bvm_saturday_loses_to_most_holy_name_of_mary_2026;
+ Alcotest.test_case
+ "RG112(d), fix round 1 (F1): the BVM Saturday office excludes Mt Carmel's own commemoration \
+ (2033-07-16)"
+ `Quick test_bvm_saturday_excludes_mt_carmel_2033
] )