diff options
Diffstat (limited to 'test/test_differential.ml')
| -rw-r--r-- | test/test_differential.ml | 43 |
1 files changed, 15 insertions, 28 deletions
diff --git a/test/test_differential.ml b/test/test_differential.ml index a89b17b..3ca24ca 100644 --- a/test/test_differential.ml +++ b/test/test_differential.ml @@ -164,7 +164,7 @@ let allow_list_path = "../data/ef/expected-divergences.sexp" deliberately, after re-running the exact command the provenance note names -- never by copying the actual value back in to make a mismatch pass, which would defeat the point of pinning it at all. *) -let fixture_sha256 = "8c0b9d9fc284138e69dbbbd87e9153a17f1abb69a39928464d83d248a819f376" +let fixture_sha256 = "a3092e3f465c2a369ae060c2c310cd3087918b821ea839bf06276ab9d82a10ce" (* Same technique tools/bootstrap_sanctoral.ml already uses for this exact purpose (that file's own comment: shelling out to the system's @@ -787,32 +787,20 @@ let lectio_no_reading_slugs = alongside the id is the same discipline this file's own header already applies to C2-C5/C7/C9-C13 (closed, cited, never left as dead code). *) -(* C22 (task 8, fix round 1, coordinator review, Critical 2): the Lenten - Ember days (RG 91 entry 18, colitur's own ef-lent-ember-{wed,fri,sat}) - are reachable for the first time this fix round -- tools/ - bootstrap_lectionary.ml's own [colitur_keys] comment has the full - account of the dead-key bug this closes. lectio's own SLUG for these - three days already matched colitur's (both call it "ef-lent-ember-wed" - etc, confirmed by this row's own [c.slug]/[l.slug] agreement -- no - [Slug_f] in this entry's own diff set), but lectio's own READING - resolution has the IDENTICAL internal mismatch colitur's used to have: - its own ini keys this data under "ef-lent-1-<weekday>", and its own - [caldata.Readings] never reaches it either, so it still falls back to - Lent I Sunday's own Mass (e.g. "2 Cor. 6:1-10"/"Matt 4:1-11") on every - one of these dates. That is a genuine LECTIO bug, reported here for - upstream, NOT fixed in this task (the brief's own triage rule: record, - do not patch the sibling project) -- and it is exactly the "Holy - Thursday was violet in both" shape this project's own CLAUDE.md already - names: layer 3 was STRUCTURALLY BLIND to this the whole time colitur - also had the bug, because both engines independently produced the same - wrong answer. Gated on colitur's own slug family (a literal 3-member - list, not a pattern) and the diff set staying [First_f; Gospel_f] - alone (slug/rank/colour already agree). Derived directly from the OCaml - comparator's own failure output, not hand-counted first and cross- - checked after: 128 (43 + 43 + 42 -- a few of the 46-year population are - impeded by a competing sanctoral feast each year, so the Ember office - itself is not always the observed day). *) -let lent_ember_slugs = [ "ef-lent-ember-wed"; "ef-lent-ember-fri"; "ef-lent-ember-sat" ] +(* C22 -- CLOSED, Task 9 (branch ef-lectionary), REMOVED not re-adjudicated + to a different verdict: 0 of 16801 rows now. It allow-listed the Lenten + Ember days (RG 91 entry 18, colitur's own ef-lent-ember-{wed,fri,sat}), + where lectio's own lectionary keyed the data under the generic + "ef-lent-1-<weekday>" family while its calendar computed the Ember + spelling, so its own [caldata.Readings] never reached it and it fell back + to Lent I Sunday's Mass. The entry named that as a genuine lectio bug for + upstream and declined to patch the sibling project (the brief's own triage + rule); it is now fixed there (lectio v0.46.1) and the fixture regenerated, + so both engines show the Ember day's own proper and there is nothing left + to allow-list. Full account in data/ef/expected-divergences.sexp's own + closure note. [lent_ember_slugs] is gone with it -- its only reader was + this predicate. *) + (* C23 (task 8, fix rounds 1-2, coordinator review, Critical 1): Holy Week's own citations (tools/bootstrap_lectionary.ml's own @@ -1208,7 +1196,6 @@ let layer_c_reason (l : row) (c : row) diffs = && List.mem c.slug lectio_no_reading_slugs then Some "C20" else if List.mem c.slug rg69_one_hop_slugs && diffs = [ First_f; Gospel_f ] then Some "C25" - else if List.mem c.slug lent_ember_slugs && diffs = [ First_f; Gospel_f ] then Some "C22" else if List.mem c.slug holy_week_slugs && diffs = [ First_f; Gospel_f ] then Some "C23" else if String.equal c.slug passion_tuesday_slug && diffs = [ First_f; Gospel_f ] then Some "C26" else if String.equal c.slug advent_ember_sat_slug && diffs = [ First_f; Gospel_f ] then Some "C27" |