summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
Diffstat (limited to 'test')
-rw-r--r--test/test_oracle.ml10
-rw-r--r--test/test_validate.ml13
2 files changed, 17 insertions, 6 deletions
diff --git a/test/test_oracle.ml b/test/test_oracle.ml
index 152464a..ac8d95d 100644
--- a/test/test_oracle.ml
+++ b/test/test_oracle.ml
@@ -56,9 +56,13 @@
entries; RG 110's inseparable-Peter/Paul commemoration is unimplemented
code, a real feature this task did not build) -- honestly verdicted
[missalemeum] (colitur is short a feature or a row, not right), never
- silently absorbed as if colitur were correct. One entry (M13) is
- [verdict open]: adjudicated as unresolved, not resolved either way --
- the brief's own explicit permission ("say so as an open item") used for
+ silently absorbed as if colitur were correct. TWO entries (M11 and
+ M13) are [verdict open] -- CORRECTED, final fix wave, item 7: this
+ comment previously said "one entry (M13)", missing M11, whose own
+ verdict was changed from [colitur] to [open] in fix round 1 (see M11's
+ own entry below for why) but this summary was never updated to match.
+ Both are adjudicated as unresolved, not resolved either way -- the
+ brief's own explicit permission ("say so as an open item") used for
real, not defaulted past. See the task report for every entry's full
reasoning and primary-source citation. *)
diff --git a/test/test_validate.ml b/test/test_validate.ml
index ee7f288..89053c1 100644
--- a/test/test_validate.ml
+++ b/test/test_validate.ml
@@ -79,9 +79,16 @@ let test_easter_extremes () =
let ys = extreme_years () in
(* Both extremes genuinely occur in 1583..2500 (earliest 1598, latest
1666 -- verified against Computus.gregorian_easter directly, not
- transcribed); requiring just "non-empty" would have passed even if the
- search silently found only one of them (register finding 15). *)
- Alcotest.(check int) "found both extreme years (earliest 22 Mar and latest 25 Apr)" 2 (List.length ys);
+ transcribed). CORRECTED (final fix wave, item 7): this used to assert
+ only [List.length ys = 2], a cardinality check where an identity check
+ was called for -- the comment already named 1598 and 1666, but nothing
+ confirmed [ys] actually contained THOSE two years rather than some
+ other pair the search happened to find first; a version of
+ [extreme_years] that silently found the wrong two years but still
+ found exactly two would have passed this unchanged. Asserting the
+ identities directly is strictly stronger and costs nothing extra. *)
+ Alcotest.(check (list int)) "found exactly 1598 (earliest 22 Mar) and 1666 (latest 25 Apr)"
+ [ 1598; 1666 ] ys;
List.iter check_year ys
(* The confidence-to-9999 core: random years across the whole domain. *)