From f8d694d0cc19b71598e1ab64254efb069969f0a0 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Sat, 15 Aug 2026 00:36:43 +0200 Subject: kernel+ef: fix round 1 -- lectionary caller-supplied, not eager Critical (coordinator review): a clean `dune build` produced a `colitur` that died at startup on EVERY subcommand, including ones touching no lectionary data at all. Root cause was two-fold: data/ef/lectionary.sexp was never added to the root default-build alias (only materialised as a side effect of the test suite's own deps, which is why every check in the prior report passed), and Rite_ef.context loaded it as a module-init side effect via failwith, undoing Lectionary.load's own "never raises" promise at a point no caller could catch. Fixed structurally: Rite_ef.context is now a function taking ~lectionary, Lectionary_ef.readings takes ~lectionary, and neither touches the filesystem any more -- the same caller-supplied discipline the sanctoral layer already had, restoring rite_ef.mli's own pre-existing claim about it and leaving a seam for a future diocesan lectionary overlay. bin/main.ml grows load_ef_lectionary, a sibling of load_ef_layer, routed through the same colitur: %s / exit 2 path. data/ef/lectionary.sexp added to the root default alias. Every caller of Rite_ef.context updated to supply it. Also: two new tests that genuinely distinguish chain step 1 from step 2 (19 March 2026, Joseph's own proper over a competing temporal entry; 13 January 2030, Holy Family reached only through the temporal slug, the Baptism entirely absent) -- the prior two tests both survived swapping the chain order. Both new pins verified directly against the real data. The chain's own comment now states plainly that its warrant is lectio's observed behaviour, not a confirmed Missal citation, per the rules register's own open item. --- dune | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'dune') diff --git a/dune b/dune index 8a00001..b7cd19b 100644 --- a/dune +++ b/dune @@ -16,9 +16,17 @@ ; (the package's own install artifacts -- executables, libraries, reached ; recursively through every subdirectory's own `install` alias) so this ; ADDS a requirement rather than replacing dune's own default behaviour. +; +; data/ef/lectionary.sexp added here for the identical reason (Task 4 fix +; round 1, coordinator review): `colitur day ` needs it at runtime +; (bin/main.ml's own [load_ef_lectionary]), and the same clean-build gap +; this file was originally written to close applied to it too -- a fresh +; `dune build` left it absent from _build/default/data/ef/, only ever +; materialised there as a side effect of test/dune's own deps. (alias (name default) (deps (alias_rec install) data/ef/sanctoral.sexp - data/ef/adjustments.sexp)) + data/ef/adjustments.sexp + data/ef/lectionary.sexp)) -- cgit v1.3