From 8b6c0036cb6c7f0e48a9370f53be25fd2bb243f4 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Tue, 11 Aug 2026 11:54:16 +0200 Subject: kernel: fix sexp deriving, add missing tests, canonicalize remove Use [@@deriving sexp] with open Sexplib0.Sexp_conv instead of hand-rolling converters (fixes non-standard Citation shape and missing field validation). Names.t_of_sexp wraps derived version to enforce canonical sort on load. Add tests: - Names of_list duplicate handling - Names sexp canonical sort guarantee (identical serialization) - Names and Date_spec sexp roundtrips Fix Names.remove to canonicalize output (defensive against non-canonical input). --- lib/kernel/date_spec.mli | 3 --- 1 file changed, 3 deletions(-) (limited to 'lib/kernel/date_spec.mli') diff --git a/lib/kernel/date_spec.mli b/lib/kernel/date_spec.mli index 600f1eb..3fe9625 100644 --- a/lib/kernel/date_spec.mli +++ b/lib/kernel/date_spec.mli @@ -1,9 +1,6 @@ (** A sanctoral entry's date expression. *) type t = Fixed of { month : int; day : int } [@@deriving sexp] -val sexp_of_t : t -> Sexplib0.Sexp.t -val t_of_sexp : Sexplib0.Sexp.t -> t - (** Validates against the leap-year maximum, so 29 February is constructible. *) val fixed : month:int -> day:int -> (t, string) result -- cgit v1.3