From 27606c42b7506ab7ffc7f1bd32d4d4a72c6400c8 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Thu, 20 Aug 2026 16:43:04 +0200 Subject: feat(render): citations render through Sigla at both call sites View.citation_ref and readings' part_ref are the only two places a citation reaches output; every emitter goes through View. --raw passes Sigla.verbatim rather than a style built over Lang.raw: an identity name table would still reformat punctuation and renumber. Loosen reject_sigla_for: --sigla-style/--sigla-book/--sigla-tradition now actually render on readings/table/render/emit/publish (each builds its own Sigla.t via the new load_sigla), and stay refused only on commands that render no citation (day, easter, temporal, ...). names_of degrades a Lang.bible miss to Book.default_spelling rather than printing the lookup key itself ("luke.abbr"); pinned in cli.t against a language file with no [bible] section at all, independent of la.ini/en.ini's own eventual [bible] section. Regenerate the 11 golden templates for 2027: every changed line is one canonical citation replacing a stored variant, verified against the full readings 2027 diff (raw vs default) cell by cell -- 86 distinct (raw, rendered) pairs account for the entire diff across all 11 files, with zero unexplained residue. Two families: the seven duplicate book spellings collapsing onto one canonical form (Isa./Isa, 3 Kgs./3 Kings, ...), and citations reconstructed from parsed structure dropping stray punctuation the parser already treats as noise (a trailing period or semicolon, a comma chapter/verse separator, an elided inherited chapter) -- each of the latter already named and tested in test_citation.ml's parse_suite before this task. --- lib/render/dune | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'lib/render/dune') diff --git a/lib/render/dune b/lib/render/dune index 548cf43..26e6d0d 100644 --- a/lib/render/dune +++ b/lib/render/dune @@ -1,5 +1,8 @@ (library (name colitur_render) - (libraries colitur_kernel colitur_naming sexplib) + ; [colitur_citation] backs [View.citation_ref]'s own [Sigla.format] call + ; (Task 9): a citation now renders through a caller-supplied style rather + ; than passing its stored reference straight through. + (libraries colitur_kernel colitur_naming colitur_citation sexplib) (preprocess (pps ppx_sexp_conv))) -- cgit v1.3