From 1935f40c156563c134f87093bf6ec8da1cf4fc46 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Thu, 20 Aug 2026 10:39:47 +0200 Subject: fix(naming): the rite prints its display name, not the internal id ef The booklet's title page and running header read "Ordo 2027 . ef" -- an internal identifier reaching a reader, the same defect class the sanctoral/temporal slugs were already fixed for. lang/la.ini and lang/en.ini each gain a [rite] section mapping the rite id to a reader-facing name, sourced from the Missal's own title page (docs/research/LT.txt:6 "MISSALE ROMANUM", :15 "EDITIO TYPICA") plus the 1962 dating this project uses throughout (rules-register.md, CLAUDE.md) -- both cited in the ini comments, marked PATTERN since the phrase combines two title-page elements rather than quoting one verbatim heading. Lang.t gains a rite table/lookup (same total, miss-echoes-the-key contract as every other lookup here); View.of_days exposes rite_name alongside the existing rite field, which stays the stable key exactly as slug is kept beside name. Every shipped template that printed {{rite}} now prints {{rite_name}} instead. test_lang_coverage.ml gains a coverage assertion over every rite id the engine can emit -- one today -- so a second rite module (OF) landing without a matching [rite] entry fails loudly instead of printing its own bare id. Goldens regenerated through the Test_view.view_of path test_render_golden.ml itself uses (English with a Latin fallback), not the CLI (whose --lang default is plain Latin and would have pinned output the tests never produce). test/cli.t's own JSON prefix assertion updated to match: rite_name is a real new key in that generic view dump, sitting right after rite. --- test/test_lang_coverage.ml | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'test/test_lang_coverage.ml') diff --git a/test/test_lang_coverage.ml b/test/test_lang_coverage.ml index 34758b2..9ed633c 100644 --- a/test/test_lang_coverage.ml +++ b/test/test_lang_coverage.ml @@ -80,6 +80,18 @@ let test_vocabularies_are_complete () = if L.month t n = string_of_int n then Alcotest.failf "no Latin month for %d" n done +(* Defect 1: the booklet used to print the bare rite id ("ef") because no + [rite] section existed in either language file. Walks every rite id the + engine can actually emit -- one today (Rite_ef.Temporal_ef.id, the same + id `Rite_ef.context` stamps onto every Rite.t.id -- see rite_ef.ml) -- so + this is cheap now and fails loudly the moment a second rite module (OF) + is wired in without a matching [rite] entry in la.ini. *) +let test_every_rite_has_a_latin_name () = + let t = la () in + List.iter + (fun id -> if L.rite t id = id then Alcotest.failf "no Latin display name for rite %S" id) + [ Rite_ef.Temporal_ef.id ] + (* lang/en.ini is DELIBERATELY partial (see its own header note): it declares [meta] fallback = la, so a slug it does not carry itself should still resolve through the chain to la.ini's name rather than degrade to the bare @@ -120,4 +132,5 @@ let suite = ( "Lang/coverage", [ Alcotest.test_case "every slug has a Latin name" `Slow test_every_slug_has_a_latin_name; Alcotest.test_case "vocabularies complete" `Quick test_vocabularies_are_complete; + Alcotest.test_case "every rite has a Latin name" `Quick test_every_rite_has_a_latin_name; Alcotest.test_case "en.ini falls back to Latin" `Quick test_en_falls_back_to_latin ] ) -- cgit v1.3