From 9108aee65dc72e7793aeb604c2e877f2898111c8 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Wed, 12 Aug 2026 05:26:15 +0200 Subject: test(oracle): correct M11's citation and verdict (fix round 1, F3) M11 (the Nativity Octave's 26/27/28 December commemoration) previously read "No RG paragraph found to support this" with verdict colitur. Wrong on both counts, found by fix-round-1 review. RG 67 ("dies infra octavam sunt II classis") and RG 109(c) ("de diebus infra octavam Nativitatis Domini") both name this commemoration; the 1962 calendarium's own text confirms it directly, verbatim, under all three dates: "S. STEPHANI PROTOMARTYRIS, II classis. / Com. octavae Nativitatis." (same pattern for John the Evangelist and the Holy Innocents). It is also a genuine regression the previous commit's own commemoration-eligibility fix introduced: before that fix, colitur happened to commemorate the day's generic Christmastide loser unconditionally, which coincidentally kept presence agreeing with the oracle even though the reasoning was wrong; the fix correctly stopped that, but 26-28 December's own temporal candidate falls through to [ferial_rank]'s Christmastide catch-all, which gives it Class4 -- the wrong ferial rank for a day RG 67 says is II class. A naive fix would also get RG 69 backwards: when this window falls on a Sunday, RG 69 names the SUNDAY as observed with a commemoration of THE FEAST ITSELF (Stephen/John/the Innocents), never the generic octave placeholder -- so this needs a commemoration that attaches to whichever named feast is observed, not one more competing RG 92-95 candidate the way everything else in this engine is modelled. Out of this fix round's own scope. Verdict changed from colitur to open: neither side is confidently right without that fix, and the previous "colitur is correct, nothing to implement" framing was itself the risk under review. --- test/test_oracle.ml | 34 +++++++++++++++++++--------------- 1 file changed, 19 insertions(+), 15 deletions(-) (limited to 'test/test_oracle.ml') diff --git a/test/test_oracle.ml b/test/test_oracle.ml index 2cc9972..152464a 100644 --- a/test/test_oracle.ml +++ b/test/test_oracle.ml @@ -410,21 +410,25 @@ let m14_dates = [ "2027-05-14" ] Verdict colitur. *) let m10_dates = [ "2026-11-30"; "2027-11-30"; "2026-12-08"; "2027-12-08" ] -(* M11 -- missalemeum's own "For Octave of the Nativity" commemoration/ - displaced entry on 26, 27(2027)/28 December carries info.rank 4 in the - raw JSON (checked directly, not inferred) -- a generic, always-present, - lowest-dignity placeholder its OWN data model seems to attach to every - day within the Nativity Octave, distinct from RG 91 entry 17's real - "days within the Octave" office (which colitur already models correctly - -- but only for 29-31 December, since 26-28 are the NAMED feasts - Stephen/John/the Innocents themselves, sanctoral not temporal, - temporal_ef.ml's own comment on [named]). No RG paragraph found here - supports a SEPARATE rank-4 commemoration alongside Stephen/John/the - Innocents' own (much higher) offices. Verdict colitur: read as - missalemeum's own bookkeeping artifact, not a liturgical fact -- flagged - as an open item rather than confidently dismissed, since the primary- - source search for this specific point was not exhaustive (see the task - report). *) +(* M11 -- CORRECTED, fix round 1 (F3): this used to claim "no RG paragraph + found" and verdict colitur. WRONG. RG 67 ("dies infra octavam sunt II + classis") + RG 109(c) ("de diebus infra octavam Nativitatis Domini") + + the calendarium's own explicit note under 26/27/28 December ("S. + STEPHANI PROTOMARTYRIS, II classis. / Com. octavae Nativitatis.", same + pattern for John the Evangelist and the Holy Innocents) all confirm a + REAL commemoration is due here -- and it is a genuine regression: before + Task 16's own commemoration-eligibility fix, colitur happened to + commemorate the day's generic Christmastide loser unconditionally + (matching presence, for the wrong reason); the fix (correctly) stopped + that, but the 26-28 December window's own temporal candidate has the + WRONG ferial rank to begin with ([ferial_rank]'s Christmastide catch-all + gives it Class4; RG 67 says II) -- and a naive fix gets RG 69's Sunday + case backwards (the Sunday, when this window falls on one, commemorates + the NAMED feast, not the generic octave placeholder). Needs new + architecture (a commemoration attached to whichever named feast wins, + not a competing RG 92-95 candidate) or a more careful fix than this + round attempted. Verdict now OPEN, not colitur -- see the sexp entry's + own full note and the task report. *) let m11_dates = [ "2026-12-26"; "2026-12-28"; "2027-12-27"; "2027-12-28" ] (* M12 -- RG 110, primary text: "In Officio et Missa S. Petri semper fit -- cgit v1.3