From 9b8821f7b914c94f5b2c8eeda05407ee921b3d5a Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Wed, 26 Aug 2026 13:30:09 +0200 Subject: feat(of-lectionary): disclose the citation-conversion residual in the header Fix option (c) from the I2 review finding, done alongside the parser fix itself rather than deferred: tools/bootstrap_lectionary_of.ml now runs every emitted reference through Colitur_citation.Parse.parse at generation time and adds a fourth COVERAGE item plus a named listing to data/of/lectionary.sexp's own header, so the 41-reference residual (all chapter-crossing hyphen ranges, see the citation-fix commit) is disclosed in the artifact a reader actually opens, not only in a task report or test file. Regenerated against the pinned lectio snapshot (dune exec tools/bootstrap_lectionary_of.exe -- ../lectio/internal/caldata/ of-lectionary.ini data/of/lectionary.sexp); diffed against the pre-change file to confirm the change is header-only, zero lines removed, the sexp payload byte-identical. Re-pins the file's own SHA-256 in test_lectionary_of.ml accordingly (re-derived with sha256sum, not transcribed from generator stdout, matching that test's own stated discipline). --- tools/dune | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'tools/dune') diff --git a/tools/dune b/tools/dune index 40e9836..7cf4440 100644 --- a/tools/dune +++ b/tools/dune @@ -34,9 +34,14 @@ ; sanctoral_slugs] reads data/of/calendar-2002.sexp and data/of/amendments/ ; by a repo-root-relative path, unlike bootstrap_lectionary.ml's own ; source/dest arguments, which are caller-supplied). +; `colitur_citation` (fix wave I2, final-review.md): the emitted header now +; runs every emitted reference through Colitur_citation.Parse.parse itself +; and names the count and the exact set that fail, so the limit is +; disclosed in the artifact a reader actually sees rather than only in a +; task report. (executable (name bootstrap_lectionary_of) - (libraries colitur_kernel rite_of unix sexplib)) + (libraries colitur_kernel colitur_citation rite_of unix sexplib)) ; Task 6 (2026-08-21-colitur-celebrant-rubrics-phase1): turns pdftotext's ; -layout dump of the Latin Mass Society Ordo into test/fixtures/ -- cgit v1.3