summaryrefslogtreecommitdiff
path: root/internal
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-09-15 22:09:06 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-09-15 22:09:06 +0200
commitbbc9b103acac96b83b150b81f2effe1b65c3f8a2 (patch)
treeb6635949ae0df8f43bf83d58df9bda57e605953e /internal
parent5d77c5b247b6da7a1d49c23b03d5522e398c7d73 (diff)
downloadkrino-bbc9b103acac96b83b150b81f2effe1b65c3f8a2.tar.gz
krino-bbc9b103acac96b83b150b81f2effe1b65c3f8a2.zip
docs: GUI design draft; code comments no longer name the owner
Diffstat (limited to 'internal')
-rw-r--r--internal/engine/exclude_test.go9
-rw-r--r--internal/extract/plain.go2
-rw-r--r--internal/extract/plain_test.go2
3 files changed, 6 insertions, 7 deletions
diff --git a/internal/engine/exclude_test.go b/internal/engine/exclude_test.go
index 3398b07..6381a04 100644
--- a/internal/engine/exclude_test.go
+++ b/internal/engine/exclude_test.go
@@ -212,8 +212,7 @@ func TestExplainReportsExclusionAndSize(t *testing.T) {
// TestExcludeFailsClosedOnUnreadableContent: an exclude meant to protect
// files holds when its content test cannot read a file (over max-read), so
-// no rule acts on a file krino could not check (review M11, Łukasz's
-// decision).
+// no rule acts on a file krino could not check (review M11).
func TestExcludeFailsClosedOnUnreadableContent(t *testing.T) {
big := "confidential " + strings.Repeat("x", 2048)
h, dl := excludeTree(t, map[string]string{"big.txt": big, "small.txt": "nothing to hide"})
@@ -273,7 +272,7 @@ func TestLoadChecksMainExcludesWithoutDirectories(t *testing.T) {
// TestNoTextFormatIsNoMatch: a file whose format has no text cannot contain
// a keyword, so a content exclude without a type does not set it aside, and
// no "content unreadable" warning is raised - while a real read failure (over
-// max-read) still fails closed (re-review N2, Łukasz's decision).
+// max-read) still fails closed (re-review N2).
func TestNoTextFormatIsNoMatch(t *testing.T) {
big := "confidential " + strings.Repeat("x", 2048)
h, dl := excludeTree(t, map[string]string{"photo.jpg": "\xff\xd8\xff\x00\x01binary", "big.txt": big})
@@ -315,8 +314,8 @@ func TestNoTextFormatIsNoMatch(t *testing.T) {
// TestTextTurningBinaryIsNoText: a file with no known extension whose first
// 8 KiB read as text but which holds a NUL further on - a self-extracting
// installer - counts as having no text, like an image: a content exclude
-// does not set it aside and there is no warning (Łukasz, after the plan 10
-// re-check: "ignore such ones").
+// does not set it aside and there is no warning (decided after the plan 10
+// re-check).
func TestTextTurningBinaryIsNoText(t *testing.T) {
mixed := "confidential " + strings.Repeat("x", 9000) + "\x00tail"
h, _ := excludeTree(t, map[string]string{"mixed": mixed})
diff --git a/internal/extract/plain.go b/internal/extract/plain.go
index ce9dedc..beffae1 100644
--- a/internal/extract/plain.go
+++ b/internal/extract/plain.go
@@ -39,7 +39,7 @@ func readDecoded(path string) (string, error) {
// sample that merely looks like UTF-8 must hold for the WHOLE file — no
// NUL byte anywhere, and no invalid UTF-8 anywhere past the sample — or
// the file is ErrUnsupported after all (a self-extracting installer has no
-// text in krino's sense, Łukasz's decision after the plan 10 re-check); the
+// text in krino's sense, decided after the plan 10 re-check); the
// Latin-1 fallback in decode
// never applies to a sniffed file, only to a file whose extension already
// names it as text. D2: when the file continues past the sample (n ==
diff --git a/internal/extract/plain_test.go b/internal/extract/plain_test.go
index c8e1008..e53ac73 100644
--- a/internal/extract/plain_test.go
+++ b/internal/extract/plain_test.go
@@ -156,7 +156,7 @@ func TestToolsListedInOrder(t *testing.T) {
// sample — sniffText must reject the whole file, not just decode what the
// sample alone promised (it must not fall back to Latin-1 the way a known
// text extension would). Such a file - a self-extracting installer, say -
-// has no text in krino's sense (Łukasz, after the plan 10 re-check).
+// has no text in krino's sense (decided after the plan 10 re-check).
func TestSniffWholeFileMustBeValid(t *testing.T) {
e := newWithPath("")
data := append([]byte(strings.Repeat("x", 8192)), 0xFF, 0x00)