1 files changed, 43 insertions, 0 deletions
diff --git a/gui/internal/model/plan_test.go b/gui/internal/model/plan_test.go
index a36cf85..1bae2c5 100644
--- a/gui/internal/model/plan_test.go
+++ b/gui/internal/model/plan_test.go
@@ -462,3 +462,46 @@ func TestKeepThisCopyRefusesANonDuplicate(t *testing.T) {
 		t.Error("a row that does not exist was accepted")
 	}
 }
+
+// TestCloseDuringApplyIsRefused: Close releases the directory lock and
+// closes the log. Called while an apply is running - which the window
+// allows: saving rules, saving settings, adding a directory and closing the
+// window all reach it - the engine goes on moving files with the log shut
+// under it, so a file is moved that no krino undo can see, and the
+// directory is unlocked while krino is still working in it.
+func TestCloseDuringApplyIsRefused(t *testing.T) {
+	conf := "(path \"~/dl\")\n(rule \"pdfs\" (when (type pdf)) (move \"Docs\"))\n"
+	e, _ := sandboxDir(t, conf, map[string]string{"a.pdf": "one", "b.pdf": "two"})
+	tab, err := Plan(context.Background(), e, e.Dirs[0])
+	if err != nil {
+		t.Fatal(err)
+	}
+	for i := range tab.Rows {
+		tab.Rows[i].Selected = true
+	}
+
+	started := make(chan struct{})
+	done := make(chan struct{})
+	tab.testBeforeApply = func() {
+		close(started)
+		// Hold the apply open while Close is attempted.
+		<-done
+	}
+	var applyErr error
+	go func() {
+		_, applyErr = tab.Apply(context.Background())
+	}()
+	<-started
+
+	if err := tab.Close(); err == nil {
+		t.Error("Close during an apply was allowed: the lock and the log go out from under it")
+	}
+	close(done)
+	// Let the apply finish before the sandbox is torn down.
+	for i := 0; i < 200 && !tab.Applied; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if applyErr != nil {
+		t.Errorf("the apply itself failed: %v", applyErr)
+	}
+}