aboutsummaryrefslogtreecommitdiff
path: root/internal/engine
Commit message (Collapse)AuthorAgeFilesLines
* a duplicate test in an exclude protects like one in a ruleLukasz Kasprzak2 days2-9/+57
| | | | | | | | | | | | The scopes that drive "no rule deletes a file krino found to be a duplicate" were collected from rules only. A directory whose duplicate tests lived in (exclude ...) forms had no scopes at all, so the protection never engaged: krino explain said "yes duplicate" and the next rule permanently deleted every copy. The README's promise was false in that shape, and the spec's wording permitted it. What matters is what krino knows, not which form taught it. The spec and krino.conf(5) now say so too.
* a chain that deletes itself still gives back the file it displacedLukasz Kasprzak2 days2-0/+140
| | | | | | | | | | | | | | | | | | | | | | | | (on-conflict overwrite) trashes the file in the way; §7.4 promises undo restores it. Walking a file's log entries stopped dead at a permanent delete, so the displace written earlier in the same chain was never reached: the user's file stayed in the Trash, the refusal named only the file they did not care about, and krino log called the run undone. The displaced file is a different file, so it is offered as its own entry in the undo plan, keyed by its own path - the deleted file stays refused, since nothing of it can come back, and the copy or move that preceded the delete stays unreversed too (undoing a copy whose original was then deleted would destroy the last remaining copy). The accounting matched: every reversible step of a deleted file was subtracted, its displace included, so the run read (undone). Only what genuinely cannot come back is subtracted now. End to end, the scenario from the review: the only copy of a file is displaced by an incoming one that is then permanently deleted. before: archive/ empty, "(undone)", nothing offered after: archive/a.pdf restored, run reads partly undone
* a file trashed to make room is logged the moment it is trashedLukasz Kasprzak2 days1-17/+23
| | | | | | | | | | | | | | | | | | | The displace was carried out first and logged only when the whole step finished - for a copy or a cross-device move, the entire data transfer later. A process killed in that window left the user's file in the Trash with nothing recording it: krino log said "nothing applied" and undo offered nothing. It is its own action with its own line (spec §9), so it is now written the moment trash.Put returns, through a hook ChainLogged calls before the step that needed the name begins. A displace that cannot be logged fails the step rather than compounding an unrecorded destructive act with a second one. Verified by killing krino -9 mid-copy with 600 MB in flight: before: krino log "nothing applied", 0 displace lines after: krino log "1 displaced", 1 displace line
* the module path is git.labunix.xyz/krinoLukasz Kasprzak2 days18-54/+54
| | | | | | | | | | | So that go install can find it. cgit serves no go-import meta tag, so nginx answers a ?go-get=1 request for /NAME with one pointing at https://git.labunix.xyz/NAME.git; the alternative was carrying a .git suffix through every import line forever. One sed over the imports, both go.mod files, and the dependency gate's whitelist. Nothing else depends on the path. go install works from the next tag, the first release whose go.mod carries it.
* comments that explain the code, not how it was writtenLukasz Kasprzak2 days13-372/+329
| | | | | | | | | | | | | | | | | | About 340 comments cited the development process: task and plan numbers, fix waves, rulings, reviewers, and the author in the third person with a date. None of that exists outside the work itself, so to a reader it pointed at nothing. Each one now states the engineering reason it was standing in front of; where a comment was provenance and nothing else, it is gone. References to docs/design.md and docs/gui-design.md by section stay: both ship with the repository. The design documents lose their amendment diaries - CHANGELOG.md is that record - and the GUI's says plainly that the window has gone further than the document. Only comments changed. Every .go file was parsed and its code printed with comments stripped, before and after: the two hashes are identical across all 175 files.
* gui: name the other copy of a duplicate, and offer to keep this one insteadLukasz Kasprzak2 days3-0/+54
|
* gui: History and undo tab; each plan and undo is its own runLukasz Kasprzak3 days2-2/+55
|
* milestone 1 review: claims span the run, explain's chain is opt-in and its ↵Lukasz Kasprzak4 days4-20/+209
| | | | own, overrides keyed by clean path, splice and enum guards
* undo runs through the same sessionLukasz Kasprzak4 days2-10/+89
|
* the engine owns a run: lock, log, run id, claimsLukasz Kasprzak4 days2-0/+266
|
* explain reports captures and the chain a file would getLukasz Kasprzak4 days3-18/+108
|
* config and engine can load with unsaved textLukasz Kasprzak4 days2-1/+26
|
* check refuses an empty time format; krino.conf(5) corrected from the re-auditLukasz Kasprzak4 days1-0/+2
|
* check refuses placeholders that could never expandLukasz Kasprzak4 days2-0/+43
|
* an undecided (stop) rule ends the search for that fileLukasz Kasprzak4 days2-0/+52
|
* a failed duplicate lookup is unknown, like unreadable contentLukasz Kasprzak4 days2-1/+30
|
* docs: GUI design draft; code comments no longer name the ownerLukasz Kasprzak4 days1-5/+4
|
* a rule's duplicate check failure shortens the path tooLukasz Kasprzak5 days2-8/+74
|
* (matched) is unknown after an undecided rule, so a catch-all leaves an ↵Lukasz Kasprzak5 days4-7/+52
| | | | unreadable file alone
* explain walks the directory for a duplicate test in an exclude tooLukasz Kasprzak5 days2-3/+44
|
* partial reads never cached; extractor version 3 discards 0.0.7 cachesLukasz Kasprzak5 days1-0/+28
|
* tests: apply error exits 1 and w stops krino through the real command; undo ↵Lukasz Kasprzak5 days1-0/+53
| | | | projection occupied half
* build: VERSION checked for build and install, cross names without v, ↵Lukasz Kasprzak5 days1-0/+37
| | | | dependency gate covers tests and BSDs, tarball install, examples and extractor list tested
* main excludes checked with the defaults' case and fold; Latin-1 decoding ↵Lukasz Kasprzak5 days2-1/+12
| | | | memory; hardlink election documented
* output: wrap by terminal columns, names cannot fake step lines, -v lists ↵Lukasz Kasprzak5 days1-2/+26
| | | | unscanned destinations
* duplicate warnings share one formatLukasz Kasprzak5 days2-5/+71
|
* literal braces are text, not placeholders, for containment and walk exclusionLukasz Kasprzak5 days2-3/+4
|
* explain: shows a duplicate's skipped delete, leaves the cache alone, walks ↵Lukasz Kasprzak5 days2-3/+42
| | | | only for duplicate tests
* content tests are three-valued: unknown when unreadable or read in partLukasz Kasprzak5 days2-2/+82
|
* captures keep the name's diacriticsLukasz Kasprzak5 days1-0/+21
|
* text that turns binary further on has no content, like an imageLukasz Kasprzak5 days1-6/+8
|
* plan 10 re-check: cut run column, damaged undo run, emptied directory ↵v0.0.7Lukasz Kasprzak5 days3-1/+123
| | | | cleanup, text turning binary, explain flags, interrupt docs
* plan 10: missing and weak tests (per-step logging, trash path, fuzz oracle, ↵Lukasz Kasprzak5 days2-2/+62
| | | | w after error)
* plan 10: an interrupt stops between steps; nohup keeps ignoring hangupsLukasz Kasprzak5 days1-3/+3
|
* plan 10: resumed undo re-checks what an earlier undo put back; occupied ↵Lukasz Kasprzak5 days2-2/+98
| | | | directory removals are not offered forever
* plan 10: a damaged log line refuses only its file, not the runLukasz Kasprzak5 days2-0/+50
|
* plan 10: a step that ran but could not be logged is named in the errorLukasz Kasprzak5 days2-1/+66
|
* plan 10: a format with no text is no match, not unreadableLukasz Kasprzak5 days2-1/+50
|
* plan 9: property test compares directories and refuses to pass vacuously; ↵Lukasz Kasprzak5 days3-14/+60
| | | | undo tracks directories trash restores recreate
* plan 9: undo review matches review, --min-age validated, future mtimes, rule ↵Lukasz Kasprzak5 days1-1/+1
| | | | names, conflict enum, dependency gate, absolute tool paths
* plan 9: content excludes fail closed; krino.conf excludes checked without ↵Lukasz Kasprzak5 days3-5/+82
| | | | directories
* plan 9: keyword cache keys on extension, max-read and Unicode tables, trims ↵Lukasz Kasprzak5 days3-9/+79
| | | | removed keywords
* plan 9: an interrupted or failed undo can be finishedLukasz Kasprzak5 days2-2/+68
|
* plan 9: undo checks trash identity, groups by directory, re-checks at ↵Lukasz Kasprzak5 days3-31/+314
| | | | execution, removes directories it recreates
* plan 9: apply logs each step as it completes and stops a chain that landed ↵Lukasz Kasprzak5 days1-5/+7
| | | | elsewhere
* plan 8: generated apply and undo round trip; undo reverses chains within one ↵Lukasz Kasprzak5 days3-0/+266
| | | | file
* plan 8: enum values read from source must all be handledLukasz Kasprzak5 days1-0/+35
|
* plan 8: fuzz decoders; fold ẞ and invalid UTF-8 correctly, refuse ↵Lukasz Kasprzak5 days1-1/+9
| | | | non-UTF-8 paths in krino new
* krino: 0.0.5 — keyword cache, t and d in reviewv0.0.5Lukasz Kasprzak5 days7-157/+391
|
* 0.0.4: max-size, exclude forms, --min-agev0.0.4Lukasz Kasprzak5 days3-10/+295
|
generated by cgit v1.3 (git 2.53.0) at 2026-09-19 15:39:29 +0000