From c497d173b24b1b8247fac9e996e5c0fe690c1769 Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Mon, 14 Sep 2026 21:43:23 +0200 Subject: plan 9: undo review matches review, --min-age validated, future mtimes, rule names, conflict enum, dependency gate, absolute tool paths --- internal/extract/extract.go | 5 ++++- internal/extract/tools_test.go | 15 +++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) (limited to 'internal/extract') diff --git a/internal/extract/extract.go b/internal/extract/extract.go index 9768db1..ad51c00 100644 --- a/internal/extract/extract.go +++ b/internal/extract/extract.go @@ -99,7 +99,10 @@ func newWithPath(path string) *Extractor { tools := make(map[string]string, len(toolNames)) for _, name := range toolNames { for _, dir := range dirs { - if dir == "" { + // A relative entry would find a tool relative to the working + // directory - a bin/pdftotext an unpacked download left behind + // (review planapply F7) - so only absolute entries count. + if dir == "" || !filepath.IsAbs(dir) { continue } p := filepath.Join(dir, name) diff --git a/internal/extract/tools_test.go b/internal/extract/tools_test.go index b481e8a..756903d 100644 --- a/internal/extract/tools_test.go +++ b/internal/extract/tools_test.go @@ -261,3 +261,18 @@ func TestFingerprintFollowsTools(t *testing.T) { t.Error("replacing pdftotext did not change the fingerprint") } } + +// TestToolLookupSkipsRelativePathEntries: a relative PATH entry would make +// a tool's path relative to the working directory - a bin/pdftotext left by +// an unpacked download - so it is ignored (review planapply F7). +func TestToolLookupSkipsRelativePathEntries(t *testing.T) { + wd := t.TempDir() + if err := os.Mkdir(filepath.Join(wd, "bin"), 0o755); err != nil { + t.Fatal(err) + } + fakeTool(t, filepath.Join(wd, "bin"), "pdftotext", "echo injected") + t.Chdir(wd) + if e := newWithPath("bin"); e.tools["pdftotext"] != "" { + t.Errorf("tool found through a relative PATH entry: %q", e.tools["pdftotext"]) + } +} -- cgit v1.3