aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--internal/web/server.go6
-rw-r--r--internal/web/templates/settings.html9
2 files changed, 7 insertions, 8 deletions
diff --git a/internal/web/server.go b/internal/web/server.go
index f02bc12..3d3db7e 100644
--- a/internal/web/server.go
+++ b/internal/web/server.go
@@ -845,13 +845,13 @@ func settingsPost(s *server) http.HandlerFunc {
cfg.WebDisplay = config.NormalizeDisplay(r.PostForm.Get("web_display"))
cfg.WebTheme = r.PostForm.Get("web_theme")
cfg.DefaultVersion = r.PostForm.Get("default_version")
- cfg.Versions = r.PostForm["versions"]
cfg.WebVersions = r.PostForm["web_versions"]
cfg.All = r.PostForm.Get("all") != ""
cfg.WebMono = r.PostForm.Get("web_mono") != ""
cfg.WebPort = atoiOr(r.PostForm.Get("web_port"), cfg.WebPort)
- // offline, width and pager are not web-editable; their config values are
- // preserved (the form no longer carries those fields).
+ // versions (the terminal compare set), offline, width and pager are not
+ // web-editable; their config values are preserved (the form no longer
+ // carries those fields).
booksText := r.PostForm.Get("books")
diff --git a/internal/web/templates/settings.html b/internal/web/templates/settings.html
index 8e18278..cb753ae 100644
--- a/internal/web/templates/settings.html
+++ b/internal/web/templates/settings.html
@@ -67,11 +67,10 @@
</select>
</label>
- <div class="row">
- {{.L.WebVersions}}
- {{range .VersionOpts}}<label><input type="checkbox" name="versions" value="{{.Code}}" {{if .Checked}}checked{{end}}> {{.Code}}</label>{{end}}
- </div>
-
+ {{/* The terminal compare set (config "versions") is intentionally NOT here:
+ it only affects the CLI, so editing it from the web is pointless and
+ confusing. settingsPost preserves it. This page keeps only the web's
+ own defaults: the single default_version and the web_versions ticks. */}}
<div class="row">
{{.L.WebWebVersions}}
{{range .WebVersionOpts}}<label><input type="checkbox" name="web_versions" value="{{.Code}}" {{if .Checked}}checked{{end}}> {{.Code}}</label>{{end}}