From 4722236b26d3439ed56893cb2863121bb705c7cf Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Wed, 12 Aug 2026 13:06:47 +0200 Subject: test(ef): un-gate the oracle test now the seven defects are fixed Remove the LECTIO_EF_ORACLE_STRICT gate added when the strengthened rank/colour assertions first landed. All seven defects are fixed as of the previous four commits; TestOracleEF now passes unconditionally as part of the normal go test ./... run, with its small, cited allow-list (four entries, none of them one of the seven) doing the only remaining filtering. --- internal/calendar/oracle_ef_test.go | 10 ---------- 1 file changed, 10 deletions(-) (limited to 'internal/calendar/oracle_ef_test.go') diff --git a/internal/calendar/oracle_ef_test.go b/internal/calendar/oracle_ef_test.go index cde4393..7a1b61e 100644 --- a/internal/calendar/oracle_ef_test.go +++ b/internal/calendar/oracle_ef_test.go @@ -214,16 +214,6 @@ func efAllowed(date string, day time.Time, oracle efOracleDay, field string) (bo // why several precedence/colour defects (see precedence_ef.go, temporal_ef.go) // shipped without ever failing a test. func TestOracleEF(t *testing.T) { - // TEMPORARY gate (removed once the seven EF precedence defects it exposed - // are fixed, see git history for the un-gating commit): landing this - // strengthened assertion set immediately turns it red -- that is the - // point, it is the regression net the fixes are built against -- but the - // repo's own rule is "go test ./... green at every commit", so the red - // state stays reproducible (`LECTIO_EF_ORACLE_STRICT=1 go test ./...`) - // without failing the default build while the fixes land commit by commit. - if os.Getenv("LECTIO_EF_ORACLE_STRICT") == "" { - t.Skip("gated pending the EF precedence fixes; set LECTIO_EF_ORACLE_STRICT=1 to run for real") - } raw, err := os.ReadFile("testdata/oracle-ef.json") if err != nil { t.Skip("EF oracle snapshot missing; run scripts/build-oracle-ef.sh") -- cgit v1.3