From e6665bd3f9ae011f65788004e4eab4472a461e8f Mon Sep 17 00:00:00 2001 From: Lukasz Kasprzak Date: Fri, 24 Jul 2026 15:04:12 +0200 Subject: web: don't clobber books.toml when the settings books field is empty --- internal/web/server_test.go | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) (limited to 'internal/web/server_test.go') diff --git a/internal/web/server_test.go b/internal/web/server_test.go index ee36318..61546b8 100644 --- a/internal/web/server_test.go +++ b/internal/web/server_test.go @@ -567,3 +567,33 @@ func TestSettingsPostInvalidBooks(t *testing.T) { } func bibleDefaultBooks() []byte { return bible.DefaultBooksTOML() } + +// TestSettingsPostEmptyBooksPreservesFile guards that a submit without a books +// field never clobbers an existing books.toml override. +func TestSettingsPostEmptyBooksPreservesFile(t *testing.T) { + dir := t.TempDir() + t.Setenv("LECTIO_CONFIG", filepath.Join(dir, "config.toml")) + booksPath := filepath.Join(dir, "books.toml") + original := []byte("[en]\nJohn = [\"Jn\", \"John\"]\n") + if err := os.WriteFile(booksPath, original, 0o644); err != nil { + t.Fatal(err) + } + srv := NewServer(config.Default()) + form := url.Values{} + form.Set("lectionary", "new") + form.Set("ui_language", "en") + form.Set("web_display", "vertical") + form.Set("web_theme", "transfiguration") + form.Set("default_version", "bt") + form["versions"] = []string{"bt"} // no "books" field + post := httptest.NewRequest("POST", "/settings", strings.NewReader(form.Encode())) + post.Header.Set("Content-Type", "application/x-www-form-urlencoded") + rec := httptest.NewRecorder() + srv.ServeHTTP(rec, post) + if rec.Code != http.StatusSeeOther { + t.Fatalf("status %d", rec.Code) + } + if got, _ := os.ReadFile(booksPath); string(got) != string(original) { + t.Errorf("empty books submit clobbered books.toml: got %q", got) + } +} -- cgit v1.3