diff options
| author | Lukasz Kasprzak <lukas@labunix.xyz> | 2026-08-12 10:15:33 +0200 |
|---|---|---|
| committer | Lukasz Kasprzak <lukas@labunix.xyz> | 2026-08-12 10:15:33 +0200 |
| commit | 37e058066a5f17db6c3d577703c0a39065ea8117 (patch) | |
| tree | 26dea2cddb863d1ad901ac3c57f9d8dc3a00883c /dune-project | |
| parent | b8e1e2376de17feeb4d0b331f1febbc4ffe478e5 (diff) | |
| download | colitur-37e058066a5f17db6c3d577703c0a39065ea8117.tar.gz colitur-37e058066a5f17db6c3d577703c0a39065ea8117.zip | |
kernel(precedence-ef): fix precedence_ef.mli's stale RG33/RG26/RG111(b) contract
The .mli's disposition doc still said a Class1-or-Class2 vigil is Omit
(RG 33) -- the pre-Task-16 mistranscription the register corrects at its
RG 33 entry. The .ml has read Class2 || Class3 since commit 079e332; the
.mli never caught up. It also named only vigil_suffix, when the vigil
test the code actually runs also checks vigil_prefix (the shape the
sanctoral bootstrap's four real vigils use); omitted RG 26's Class4
temporal-ferias-are-never-commemorated branch entirely, then asserted the
listed cases 'exhaust every representable shape', which was false as
written; and omitted RG 111(b)'s 'de festo II classis' rank floor from
admit's doc, describing only the privilege-override half of that rule.
Fixed all four: the vigil-omission bullet now names Class2/Class3 and
both slug conventions; the missing RG 26 branch is now documented,
folding the exhaustiveness claim into an accurate five-branch count;
admit's Sunday case now states the rank floor as a second, independent
condition.
The same stale RG 109(e) reading this interface carried ('leaves the
Advent and Lent Ember sets ordinary') also survived as the stated reason
september_ember_prefix exists, in the .ml, about 330 lines from the
already-corrected privilege_of comment it contradicts. Fixed there too:
September is broken out because it sits outside RG 109(e)'s three named
seasons entirely, not because Advent/Lent Ember needs excluding from (e)
-- it does not, per privilege_of's own corrected comment.
No behaviour change: both fixes are doc-comment-only edits to already-
correct code (precedence_ef.ml's disposition/admit implementations were
fixed in an earlier commit; only the .mli's prose and one earlier .ml
comment lagged).
Diffstat (limited to 'dune-project')
0 files changed, 0 insertions, 0 deletions
