aboutsummaryrefslogtreecommitdiff
path: root/lib/kernel/celebration.ml
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-08-19 13:48:39 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-08-19 13:48:39 +0200
commit59fbd3718dbf2721557b97d7b4e87dce38fb745c (patch)
tree818feefb15c328bca3ecf9b1a24a2023d57980c4 /lib/kernel/celebration.ml
parent6bdd5afc5e185b639f9cf5e7c3d662ddc3ecf0e1 (diff)
downloadcolitur-59fbd3718dbf2721557b97d7b4e87dce38fb745c.tar.gz
colitur-59fbd3718dbf2721557b97d7b4e87dce38fb745c.zip
fix(naming): config fix round 1 -- unknown sections, O(n) accumulate
F1: test_unknown_key_is_reported_not_fatal never asserted unknown_keys itself, only that parsing survives -- a no-op accumulator passed it. Now asserts the key is actually collected. F2: a misspelled section name, e.g. [deafults], was silently discarded -- Ok empty, lang and everything else gone, nothing reported. That is the highest-value typo this feature exists to catch. Any section other than [defaults] is now collected into a new Config.unknown_sections, kept separate from unknown_keys so the CLI can word the two warnings differently. Still non-fatal: a newer colitur's added section must not break an older binary. F3: overlays and unknown_keys accumulated with '@ [v]' per line, O(n^2) over the field count. Cons during the fold, List.rev once at the end. F4: documented that lang/template/format are last-wins on a repeated key, the opposite direction from Overlay_ini.get's first-wins over the same section type.
Diffstat (limited to 'lib/kernel/celebration.ml')
0 files changed, 0 insertions, 0 deletions