merge: celebrant Mass rubrics, and four rubrical corrections

colitur now prints what a real ordo prints for the Mass: which formulary is
said and how it was reached, the Gloria, the Creed, the preface, and the
commemorations with their Low-Mass/sung distinction. colitur rubrics joins
day and readings.

Four defects were found and fixed on the way, each by an external witness
rather than by inspection: the Creed said at Requiem Masses (RG 476(f)),
the missing bissextile shift of St Matthias and St Gabriel (2 041 leap
years), Rogation Monday and Tuesday coloured violet in Paschaltide (RG
119(b)), and the ferias after the Ascension resuming the wrong Sunday's
Mass rather than the Ascension's.

Validation gained a sixth layer and then some: the preface is checked
against three independent publishers over seven witness-years (FIUV, three
LMS editions, three extraordinaryform.org editions), none of which shares
the Divinum Officium -> missalemeum -> lectio lineage the older layers all
descend from.

1 files changed, 30 insertions, 1 deletions

diff --git a/lib/kernel/validate.ml b/lib/kernel/validate.ml
index c9d4263..f523b39 100644
--- a/lib/kernel/validate.ml
+++ b/lib/kernel/validate.ml
@@ -239,7 +239,7 @@ let run (rite : ('s, 'r) Rite.t) (layer : 'r Layer.t) ~year =
        let expected : (string, int) Hashtbl.t = Hashtbl.create 64 in
        List.iter
          (fun date ->
-           Layer.on_date idx date
+           Layer.on_date ~fixed_key:rite.Rite.fixed_key idx date
            |> List.iter (fun (e : 'r Layer.entry) ->
                   bump expected (Slug.to_string e.Layer.cel.Celebration.slug)))
          days;
@@ -453,5 +453,34 @@ let run (rite : ('s, 'r) Rite.t) (layer : 'r Layer.t) ~year =
                  fail date "citations"
                    (Printf.sprintf "expected exactly one First and one Gospel, got [%s]"
                       (String.concat "," (List.map Citation.part_to_string sorted))))
+           resolved;
+       (* ---- Formulary invariant (Task 3, celebrant-rubrics-phase1) ----
+
+          Same rite-agnostic gating as the citation checks immediately
+          above, and for the same reason: a rite whose lectionary is not
+          built returns [(None, [])] from {!Rite.readings} on every day, so
+          [year_has_formulary] is false and this check never fires for it.
+          A rite that resolves a formulary AT ALL is held to resolving one
+          on every day of the year -- a day that says no Mass at all is a
+          defect, not a gap, the same discipline the ["citations-unresolved"]
+          check above already holds for the citations themselves. One check
+          name, not two: unlike [citations], there is no separate
+          "well-formed but wrong" shape to distinguish -- [Mass_formulary.t
+          option] is either the day's answer or it is missing, so
+          [year_has_formulary] gates a single ["formulary"] label. *)
+       let year_has_formulary =
+         Array.exists
+           (fun (d : ('s, 'r) Liturgical_day.t) -> d.Liturgical_day.formulary <> None)
+           resolved
+       in
+       if year_has_formulary then
+         Array.iter
+           (fun (d : ('s, 'r) Liturgical_day.t) ->
+             match d.Liturgical_day.formulary with
+             | Some _ -> ()
+             | None ->
+                 fail d.Liturgical_day.date "formulary"
+                   "no Mass formulary resolved for this day: the lectionary chain fell through \
+                    every step")
            resolved);
   List.rev !failures