aboutsummaryrefslogtreecommitdiff
path: root/test/test_golden.ml
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-08-14 12:51:19 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-08-14 12:51:19 +0200
commit148729e731370f56a50c3819a7d81808c6e602ca (patch)
treee739546256e34e16d651c69b86d8a898b50b4191 /test/test_golden.ml
parent2af482c7293d821f10c3bbc96b7913d658c5839c (diff)
parentd0468f53820585e7b4e4bfeb9a4a18f672b821a5 (diff)
downloadcolitur-148729e731370f56a50c3819a7d81808c6e602ca.tar.gz
colitur-148729e731370f56a50c3819a7d81808c6e602ca.zip
Merge branch 'ef-sanctoral-audit': the sanctoral against the Missal
The first full check of all 327 sanctoral entries against the primary calendarium, read from page images of both photographic scans rather than either PDF's OCR text layer -- the second scan's layer interleaves its two print columns row by row and is unusable. Findings that stand: St Barbara (4 December), a Commemoratio both scans carry with her own Mass propers, absent from colitur and from lectio's source alike -- 7196 clean additions, never displacing anything. And 18 colour corrections, all traced to the same bootstrap defect as the earlier eusebius-confessor fix, now shown systemic rather than isolated; several of lectio's own Polish name fields contradict its own colour tag. The Commemoration_only ranks are reframed rather than resolved: the calendarium carries 57 Commemoratio lines and not one gives a class numeral, for anyone. That is a source ceiling, not 105 open questions, and nothing a primary-source read can close. Three corrections did not survive review and are reverted here. RG 120(f) names Cathedrae S. Petri (22 februarii) and Conversionis S. Pauli (25 ianuarii) in its own enumeration of white, fifteen lines above the RG 124(b) they were cited to; RG 124(b)'s own 'in eorum die natalicio' excludes them independently; RG 475(e) confirms it a third time. Both oracles said white because both were right. The cause is worth more than the entries: the page-image method was applied to the calendarium and not to the rubric, and in the text layer the two-column interleave hyphen-splits Cathedrae so it does not grep. A text-layer read of that chapter finds 124 and cannot find 120(f). Two safeguards had been reporting this correctly and were overridden -- a golden pin asserting white, edited to red and rewritten to guard against restoring it, and two allow-lists told to ignore divergences where both oracles were correct. Both restored. Anastasia (25 December) was found and deliberately not added: she is scoped to the second of Christmas's three Masses and the data model has no Mass scope. Now recorded in the tracked tree, beside barbara, where the next auditor will be standing.
Diffstat (limited to 'test/test_golden.ml')
-rw-r--r--test/test_golden.ml20
1 files changed, 18 insertions, 2 deletions
diff --git a/test/test_golden.ml b/test/test_golden.ml
index 7b461bf..a873738 100644
--- a/test/test_golden.ml
+++ b/test/test_golden.ml
@@ -493,9 +493,25 @@ let test_ember_ferias_commemorated_when_impeded () =
[rg110_additions]). This pin's own [ef-lent-ember-sat:privileged] half
is UNCHANGED from before this task -- only [paul:ordinary] is new,
confirming RG 110 adds a genuinely SEPARATE, uncapped slot rather than
- competing for the Ember feria's own privileged one. *)
+ competing for the Ember feria's own privileged one.
+
+ CORRECTED (ef-sanctoral-audit, 2026-08-14): [chair-of-st-peter]'s own
+ colour was `white` here, matching the pre-audit bootstrap -- WRONG,
+ RG 124(b) ("XVIII - De coloribus paramentorum", both photographic
+ scans, word for word): red is used "in Officio et Missa de festis...
+ Sanctorum Apostolorum et Evangelistarum, in eorum die natalicio,
+ excepto festo S. Ioannis (27 decembris)" -- red for an Apostle's own
+ feast day, no exception for a Chair feast. Fixed via
+ data/ef/adjustments.sexp's own `Edit chair-of-st-peter ((Set_colour
+ Red))`; this pin now asserts the corrected value, catching a
+ regression back to the old one either way. *)
check ~msg:"1902-02-22: Lent Ember Saturday, impeded, MUST be commemorated (RG24) and is privileged (RG109e) -- \
- AND RG110's Paul companion rides alongside it, uncapped"
+ AND RG110's Paul companion rides alongside it, uncapped -- AND Chair of St Peter is WHITE, \
+ named by date in RG120(f)'s own enumeration of white ('Cathedrae S. Petri (22 februarii)'). \
+ THIS PIN WAS RIGHT AND WAS EDITED TO ACCOMMODATE A WRONG CHANGE: the ef-sanctoral-audit task \
+ set it to red on RG124(b), whose 'in eorum die natalicio' qualifier does not reach the Chair, \
+ and rewrote this assertion rather than treating its failure as evidence. Restored by the \
+ fix-round review. A pin that resists a change is evidence, not an obstacle"
1902 2 22
"1902-02-22 saturday season=lent week=1 slug=chair-of-st-peter rank=class-2 colour=white subject=saint \
name_la=- comms=[ef-lent-ember-sat:privileged,paul:ordinary] in=- out=[]"