fix(ef): Rogation Monday/Tuesday are white, not violet (RG 119)

Temporal_ef.temporal's Rogation Monday/Tuesday branch hardcoded
Colour.Violet with no citation (data/ef/expected-divergences-lms.sexp's
L6, surfaced by the LMS Ordo). RG 119 assigns white to the de-Tempore
Office and Mass from the Paschal Vigil Mass to the Pentecost Vigil Mass
exclusive; Easter+36/+37 sit inside that window. RG 128's own exhaustive
four-case violet list never names Rogation days, and its vigil clause
(d) is doubly inapplicable: these are not vigils, and they are inside
Paschaltide, not outside it. RG 88 explains the violet actually seen in
print sources: "de Litaniis minoribus nihil fit in Officio, sed tantum
in Missa" -- the violet belongs to the Rogation Mass/procession, a
distinct votive text this engine does not model, not to the day's own
Office. Witnessed directly: LMS Ordo 2023-2024, 2024-05-06, "FERIA IV Cl
W" with "Gl", the Office and Mass printed separately from the optional
violet votive Mass of the Rogations.

Cascade verified, not assumed: RG 432(b) omits the Gloria on every
violet Mass, so the wrong colour was also silencing the Gloria on these
two weekdays even though RG 237(e) (Breviary, ordinary Paschaltide
ferias say Te Deum) already made it true underneath. White removes the
432(b) block, and the Gloria now follows Te Deum via 431(a), matching
the Ordo's own "Gl" -- confirmed with dedicated golden pins in both
test_golden.ml (colour) and test_rubrics_ef.ml (the Gloria flip),
2028-05-22/23 (neither day impeded that year).

Closed L6 in data/ef/expected-divergences-lms.sexp. Reopened C8 in
data/ef/expected-divergences.sexp (26 of 16801 rows, 2005-2050): lectio
independently computes these two days violet too, so the two engines
used to agree by sharing the same uncited assumption; colitur's colour
is now correct and lectio's is not, so the comparator disagrees again,
for the opposite reason. While reopening C8, found and corrected a
genuine misattribution in its own prior closure note, which claimed
lectio's violet was "RG 128(d)" -- 128(d) governs vigils outside
Paschaltide and has nothing to do with Rogation days. Checked
docs/research/rules-register.md for the same claim: not present there,
but a related conflation was found and corrected at its O'Connell
section 4(d) note, which had used a Rogation MASS/procession citation to
"confirm" the day's own OFFICE colour.

Blast radius measured in-process across the full 1583-9999 domain
(throwaway probe, not committed): 4722 days total (2368 Rogation
Mondays + 2354 Rogation Tuesdays actually observed outright, i.e. not
impeded by a stronger sanctoral feast that year), all Violet->White,
all with the Gloria flipping false->true alongside, zero anomalies.

Mutation-tested: reverting the branch to Colour.Violet reddens 16 tests
across Rubrics_ef, the lectio differential, the LMS Ordo suite and both
golden pin files; restored and reconfirmed green (680 tests).

1 files changed, 32 insertions, 0 deletions

diff --git a/test/test_golden.ml b/test/test_golden.ml
index d680720..3a6f3f5 100644
--- a/test/test_golden.ml
+++ b/test/test_golden.ml
@@ -1315,6 +1315,34 @@ let test_rogation_wednesday_yields_to_a_feast_2026 () =
     "2026-05-13 wednesday season=paschaltide week=6 slug=ef-ascension-vigil rank=class-2 colour=white \
      subject=temporal name_la=- comms=[robert-bellarmine:ordinary] in=- out=[]"
 
+(* ---- Rogation Monday/Tuesday colour, RG 119/128/88 (celebrant-rubrics-
+   phase1 Bug 1 fix, 2026-08-22; data/ef/expected-divergences-lms.sexp's
+   now-closed L6, data/ef/expected-divergences.sexp's reopened C8) ----
+
+   {!Rite_ef.Temporal_ef.temporal}'s Rogation Monday/Tuesday branch used to
+   hardcode [Colour.Violet] with no citation. RG 119 assigns white to the
+   de-Tempore Office and Mass from the Paschal Vigil to the Pentecost Vigil
+   exclusive -- Easter+36/+37 sit inside that window -- and RG 128's own
+   exhaustive four-case violet list never names Rogation days; RG 88 ("de
+   Litaniis minoribus nihil fit in Officio") is why -- the violet belongs
+   to the Rogation MASS/procession alone, not the day's own Office. Fixed
+   to [season_colour s], the same call every other Paschaltide feria makes.
+
+   2028 pins BOTH days at once (unlike the LMS witness, which only reaches
+   one day per fixture window): neither is impeded by a competing
+   sanctoral feast that year, so both are observed outright, both white.
+   Verified directly against `date -d`: Easter 2028-04-16, so 22/23 May are
+   Easter+36/+37. *)
+let test_rogation_monday_white_2028 () =
+  check ~msg:"2028: Rogation Monday is white (RG 119), not violet" 2028 5 22
+    "2028-05-22 monday season=paschaltide week=6 slug=ef-rogation-monday rank=class-4 colour=white \
+     subject=temporal name_la=- comms=[] in=- out=[]"
+
+let test_rogation_tuesday_white_2028 () =
+  check ~msg:"2028: Rogation Tuesday is white (RG 119), not violet" 2028 5 23
+    "2028-05-23 tuesday season=paschaltide week=6 slug=ef-rogation-tuesday rank=class-4 colour=white \
+     subject=temporal name_la=- comms=[] in=- out=[]"
+
 (* ---- The bissextile (leap-year) calendarium footnote, bissextile-shift
    task, 2026-08-22 ----
 
@@ -1572,6 +1600,10 @@ let suite =
         test_rogation_wednesday_admitted_2024;
       Alcotest.test_case "RG87/113: Rogation Wednesday yields to an impeded feast (2026)" `Quick
         test_rogation_wednesday_yields_to_a_feast_2026;
+      Alcotest.test_case "RG119/128: Rogation Monday is white, not violet (2028)" `Quick
+        test_rogation_monday_white_2028;
+      Alcotest.test_case "RG119/128: Rogation Tuesday is white, not violet (2028)" `Quick
+        test_rogation_tuesday_white_2028;
       Alcotest.test_case "bissextile footnote: Matthias moves 24->25 February (leap, 2044)" `Quick
         test_bissextile_matthias_leap_2044;
       Alcotest.test_case "bissextile footnote: Matthias unaffected (common, 2025)" `Quick