fix(of): rename credo to creed, correct three comment inaccuracies

Fix round 1 for Task 3, addressing review findings.

Rename the exported creed function from `credo` to `creed` across the
.ml, .mli and test call sites, so the OF rite bundle can write
`creed = Rubrics_of.creed` with no gratuitous mismatch against
Rite.t's own field name, matching Rite_ef.Rubrics_ef.creed's own
naming. IGMR n. 67's own heading is "Professio fidei" and its body
says "Symbolum", never "Credo" -- documented as a comment on the
now-correctly-named function rather than kept as the exported name.
Local test helpers (credo_on_temporal, check_credo, test_credo_*) and
Alcotest description strings keep the Latin shorthand, since only the
call sites against RO.creed needed to change.

Corrected two comment inaccuracies:
- The Annunciation (25 March) is NOT always inside Lent, unlike St
  Joseph (19 March): 25 March sits after Easter's own earliest
  possible date (22 March), so in an early-Easter year (2008, Easter
  23 March) it falls inside the Easter Octave instead, or is
  transferred under Normae n. 60/5. No functional effect (gloria/creed
  read observed/temporal as actually resolved), but the stated reason
  was wrong.
- The Requiem-silence argument's counts: three All Souls Mass
  formularies (not two), and roughly 147 Gloria+Credo markers combined
  elsewhere in the Missal (not "over 150", which conflated Gloria
  alone with the combined figure) -- recounted directly against a
  fresh pdftotext -layout extraction rather than estimated.

Added: an independent corroborating citation for the Holy Thursday /
Easter Vigil Gloria exception, Vigil n. 31 -- the Easter Vigil's own
praenotanda ("VIGILIA PASCHALIS IN NOCTE SANCTA"), a THIRD
independently-numbered rubric set inside the same Missal PDF,
confirming the Vigil's own Gloria directly rather than resting solely
on the Holy Thursday rubric's forward-looking "usque ad" clause.

dune test: exit 0, 845 tests. make check (COLITUR_EXHAUSTIVE_SWEEP=1,
full 1583-9999 sweep): exit 0, 851 tests, 330.3s, both run unpiped in
the foreground. git diff --stat v1.0.0..HEAD -- lib/rites/rite_ef/
lib/kernel/ data/ef/ still empty.

1 files changed, 5 insertions, 5 deletions

diff --git a/test/test_rubrics_of.ml b/test/test_rubrics_of.ml
index db8744a..c29de8e 100644
--- a/test/test_rubrics_of.ml
+++ b/test/test_rubrics_of.ml
@@ -180,7 +180,7 @@ let test_gloria_all_souls () =
 
 let credo_on_temporal y m d =
   let temporal = T.temporal (mk y m d) in
-  RO.credo ~temporal ~observed:temporal.Colitur_kernel.Temporal.office ~date:(mk y m d)
+  RO.creed ~temporal ~observed:temporal.Colitur_kernel.Temporal.office ~date:(mk y m d)
 
 let check_credo name expected actual = Alcotest.(check bool) name expected actual
 
@@ -201,7 +201,7 @@ let test_credo_solemnity () =
     mk_saint ~slug:"joseph-husband-of-the-blessed-virgin-mary" ~rank:Vocab_of.Sollemnitas
       ~colour:Colour.White ~subject:Subject.Saint ()
   in
-  check_credo "Credo: a solemnity" true (RO.credo ~temporal ~observed ~date:(mk 2026 3 19))
+  check_credo "Credo: a solemnity" true (RO.creed ~temporal ~observed ~date:(mk 2026 3 19))
 
 let test_credo_festum () =
   (* Same Chair-of-Peter data as [test_gloria_festum] -- [false] here,
@@ -214,7 +214,7 @@ let test_credo_festum () =
       ~subject:Subject.Saint ()
   in
   check_credo "no Credo on an ordinary Festum (unlike Gloria)" false
-    (RO.credo ~temporal ~observed ~date:(mk 2027 2 22))
+    (RO.creed ~temporal ~observed ~date:(mk 2027 2 22))
 
 let test_credo_weekday_obligatory_memorial () =
   let temporal = T.temporal (mk 2027 6 21) in
@@ -223,7 +223,7 @@ let test_credo_weekday_obligatory_memorial () =
       ~colour:Colour.White ~subject:Subject.Saint ()
   in
   check_credo "no Credo on a weekday obligatory memorial" false
-    (RO.credo ~temporal ~observed ~date:(mk 2027 6 21))
+    (RO.creed ~temporal ~observed ~date:(mk 2027 6 21))
 
 let test_credo_ordinary_feria () =
   check_credo "no Credo on a plain feria" false (credo_on_temporal 2026 1 27)
@@ -233,7 +233,7 @@ let test_credo_all_souls () =
   let observed =
     mk_saint ~slug:"all-souls" ~rank:Vocab_of.Sollemnitas ~colour:Colour.Violet ~subject:Subject.Saint ()
   in
-  check_credo "no Credo on All Souls" false (RO.credo ~temporal ~observed ~date:(mk 2026 11 2))
+  check_credo "no Credo on All Souls" false (RO.creed ~temporal ~observed ~date:(mk 2026 11 2))
 
 (* ---- Preface -- always [None]; see rubrics_of.ml's own header for the
    full INDEX-PRAEFATIONUM census this rests on. One row per major class,