diff options
Diffstat (limited to 'test/test_golden.ml')
| -rw-r--r-- | test/test_golden.ml | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/test/test_golden.ml b/test/test_golden.ml index 2f8930f..8d33e29 100644 --- a/test/test_golden.ml +++ b/test/test_golden.ml @@ -94,11 +94,15 @@ let real_ef_lectionary = (* The Commons (data/ef/commons.sexp) travel the same caller-supplied seam as the lectionary above, and [~commons] is required rather than defaulted - so that no caller can silently run with none -- nothing in layers 3-5 - compares reading citations, so a rite quietly missing its Commons would - be invisible. Loaded here even where this file asserts nothing about - readings, so that the rite under test is the same one bin/main.ml - assembles. *) + so that no caller can silently run with none. CORRECTED, Task 9 fix + round 1 (coordinator review): this used to claim "nothing in layers 3-5 + compares reading citations" -- stale since Task 8 (layer 3) and Task 9 + (layer 4). THIS layer (5, golden pins) is the one that still does not: + this file's own [describe] carries no citation field at all, so a rite + quietly missing its Commons would still be invisible here specifically, + even though layers 3/4 would now catch it. Loaded here even where this + file asserts nothing about readings, so that the rite under test is the + same one bin/main.ml assembles. *) let real_ef_commons = match Rite_ef.Lectionary_ef.Commons.load commons_path with | Error e -> failwith (Printf.sprintf "%s: failed to load: %s" commons_path e) |