aboutsummaryrefslogtreecommitdiff
path: root/internal/norm
diff options
context:
space:
mode:
authorLukasz Kasprzak <lukas@labunix.xyz>2026-09-17 12:11:42 +0200
committerLukasz Kasprzak <lukas@labunix.xyz>2026-09-17 12:11:42 +0200
commitbddbd74e4a73e8e32bcf648efd1cac5655f6d0cd (patch)
tree187e6a1fb722d9ab97d2076f69f997f5d371e943 /internal/norm
parentcd7425b81f963a948f0abe7df3f9e58e190c2b78 (diff)
downloadkrino-bddbd74e4a73e8e32bcf648efd1cac5655f6d0cd.tar.gz
krino-bddbd74e4a73e8e32bcf648efd1cac5655f6d0cd.zip
comments that explain the code, not how it was written
About 340 comments cited the development process: task and plan numbers, fix waves, rulings, reviewers, and the author in the third person with a date. None of that exists outside the work itself, so to a reader it pointed at nothing. Each one now states the engineering reason it was standing in front of; where a comment was provenance and nothing else, it is gone. References to docs/design.md and docs/gui-design.md by section stay: both ship with the repository. The design documents lose their amendment diaries - CHANGELOG.md is that record - and the GUI's says plainly that the window has gone further than the document. Only comments changed. Every .go file was parsed and its code printed with comments stripped, before and after: the two hashes are identical across all 175 files.
Diffstat (limited to 'internal/norm')
-rw-r--r--internal/norm/norm.go4
-rw-r--r--internal/norm/norm_test.go4
2 files changed, 4 insertions, 4 deletions
diff --git a/internal/norm/norm.go b/internal/norm/norm.go
index 1c2f61d..9a22e62 100644
--- a/internal/norm/norm.go
+++ b/internal/norm/norm.go
@@ -20,7 +20,7 @@ const Version = 1
// Fingerprint names everything Text and Name's output depends on: Version,
// and the Unicode tables of the standard library and of x/text's
-// normalisation, which a Go or x/text upgrade can change (review cache F4).
+// normalisation, which a Go or x/text upgrade can change.
func Fingerprint() string {
return fmt.Sprintf("norm%d unicode%s nfd%s", Version, unicode.Version, unorm.Version)
}
@@ -125,7 +125,7 @@ func FoldMapped(s string) Folded {
// Source returns the original text that Text[a:b] was folded from, widened
// to whole characters and to the characters right after them that fold to
// nothing - the combining marks of a decomposed name, which belong to the
-// letter before them (plan 11 review L5); without a map, Text[a:b] itself.
+// letter before them; without a map, Text[a:b] itself.
func (f Folded) Source(a, b int) string {
switch {
case f.same || f.start == nil:
diff --git a/internal/norm/norm_test.go b/internal/norm/norm_test.go
index dfae915..9d4e214 100644
--- a/internal/norm/norm_test.go
+++ b/internal/norm/norm_test.go
@@ -76,8 +76,8 @@ func TestFoldASCIINoAlloc(t *testing.T) {
// TestFoldMappedSource: a part of the folded text leads back to the original
// characters it came from, widened to whole characters and to the combining
-// marks that follow them (a decomposed name, plan 11 review L5) - so a
-// capture can be written with its diacritics.
+// marks that follow them (a decomposed name) - so a capture can be written
+// with its diacritics.
func TestFoldMappedSource(t *testing.T) {
cases := []struct {
in, folded string