aboutsummaryrefslogtreecommitdiff
path: root/gui/internal/ui
Commit message (Collapse)AuthorAgeFilesLines
* Settings changes take effect, and keep this copy respects the planLukasz Kasprzak2 days1-3/+14
| | | | | | | | | | | | | | | | | | | | | Five of the Settings window's controls - the sort order, the three column toggles and the preview height - were read when it built its new preferences but never connected to anything, so changing them did nothing until some other control happened to fire, and then they all landed at once out of nowhere. Every control is connected now. The same closure composed a whole Prefs from its own widgets, which wrote the remembered divider positions back as zeros: dragging the panes to taste and then ticking any checkbox threw them away. A settings change is now applied over the preferences as they are, by model.Prefs.WithDisplay - which is where it can be tested, and is. "Keep this copy, replace the other" wrote a Displaces straight into the chain. internal/plan refuses to build two steps that displace one path, because the second destroys what the first put there; the window went round that code, so choosing it for two duplicates of one file left both rows saying "done" with the first file in the Trash. It now refuses the second, naming the file that has the place.
* the window cannot pull the lock out from under a running applyLukasz Kasprzak2 days3-8/+80
| | | | | | | | | | | | | | | | | | Close releases the directory lock and closes the log. The window could reach it while an apply was still running - saving rules, saving settings, adding a directory, or closing the window - and the engine then went on moving files with the log shut underneath: a file moved that no krino undo can see, the rest of the plan silently abandoned, and the directory unlocked while krino was still working in it. PlanTab and UndoTab refuse to close while their apply is in flight (model.ErrApplying), the window's close request and reloadEngine honour the refusal instead of ignoring it, and the tabs and Settings are greyed out for the duration so a button that cannot work says so by being unavailable rather than by an error afterwards. The test starts an apply, calls Close from another goroutine while it is in flight, and requires the refusal.
* the module path is git.labunix.xyz/krinoLukasz Kasprzak2 days7-18/+18
| | | | | | | | | | | So that go install can find it. cgit serves no go-import meta tag, so nginx answers a ?go-get=1 request for /NAME with one pointing at https://git.labunix.xyz/NAME.git; the alternative was carrying a .git suffix through every import line forever. One sed over the imports, both go.mod files, and the dependency gate's whitelist. Nothing else depends on the path. go install works from the next tag, the first release whose go.mod carries it.
* comments that explain the code, not how it was writtenLukasz Kasprzak2 days6-40/+33
| | | | | | | | | | | | | | | | | | About 340 comments cited the development process: task and plan numbers, fix waves, rulings, reviewers, and the author in the third person with a date. None of that exists outside the work itself, so to a reader it pointed at nothing. Each one now states the engineering reason it was standing in front of; where a comment was provenance and nothing else, it is gone. References to docs/design.md and docs/gui-design.md by section stay: both ship with the repository. The design documents lose their amendment diaries - CHANGELOG.md is that record - and the GUI's says plainly that the window has gone further than the document. Only comments changed. Every .go file was parsed and its code printed with comments stripped, before and after: the two hashes are identical across all 175 files.
* gui: the path keeps its telling end, and the checklist grows three itemsLukasz Kasprzak2 days1-2/+6
| | | | | | | | | | | Squeezed, the toolbar's path label read "/t... ds". It now elides the start, since the end of a path is the part that says which directory this is, and will not shrink below about sixteen characters; the tooltip still holds it in full. The checklist gains the reordered bar, the About block, and the sandbox trap that had every file skipped: krino's own (min-age 2m) ignores a file written in the last two minutes.
* gui: the toolbar in the order things happen, and an About blockLukasz Kasprzak2 days3-7/+30
| | | | | | | | | | | | | | The Plan bar now reads left to right as the work does: which directory, how it should be listed, what of it, where it is on disk - then Scan, and only then what to do with what came back. Scan carries the theme's accent, being the button that starts everything. Settings ends with About: the program and the version it was built as, what it is in a sentence, the licence, and who to write to. The text is model.About so it is tested; ui.Version is stamped by main. leak-check knows krino's own contact address, so the address check stays useful without a per-clone setting.
* gui: an exclude is not a rule - the form no longer assumes onev0.0.11Lukasz Kasprzak2 days2-10/+20
| | | | | | | | | | | Selecting the exclude row in Forms panicked: newFormEditor read the form's rule for its when, name, action and stop, and an exclude has only the when. The editor now takes the conditions from whichever of the two the form holds and leaves out the fields an exclude has not got. Checklist item 49 covers it. Also the 0.0.11 changelog and README, and header floors wide enough that the age heading is not clipped.
* gui: conditions as a nested tree, and a way to add a directoryLukasz Kasprzak2 days4-29/+253
|
* gui: name the other copy of a duplicate, and offer to keep this one insteadLukasz Kasprzak2 days1-5/+53
|
* gui: sort the plan by name, size, age, action or ruleLukasz Kasprzak2 days2-19/+83
|
* gui: size and age columns, column toggles, readable colours, a laid-out ↵Lukasz Kasprzak2 days3-79/+214
| | | | explanation
* gui: keep every divider where it is put, and let the columns shrinkLukasz Kasprzak2 days2-24/+97
|
* gui: an applied plan says it is history; Settings says what needs savingLukasz Kasprzak2 days2-5/+29
|
* gui: aligned columns, theme colours, a second layout, and a scan-selection ↵Lukasz Kasprzak2 days3-46/+176
| | | | setting
* gui: coloured actions with headers, a filter over the plan, bulk trash or deleteLukasz Kasprzak3 days5-56/+357
|
* gui: the preview is as big as you drag it, and PDFs render to suitLukasz Kasprzak3 days1-20/+65
|
* gui: a rendered PDF page per file, and Settings in the top rightLukasz Kasprzak3 days2-4/+30
|
* gui: syntax colours, a file preview, and a settings windowLukasz Kasprzak3 days6-8/+436
|
* gui: line numbers, a Check button, an operator for age and size, and Test ruleLukasz Kasprzak3 days2-12/+177
|
* gui: show the problems under both sub-tabs; name the operator rows; fix the ↵Lukasz Kasprzak3 days2-4/+31
| | | | list labels after an edit
* gui: size the plan and undo columns to what they hold, so the rule is never cutLukasz Kasprzak3 days2-13/+71
|
* gui: the directory's own settings as a formLukasz Kasprzak3 days1-6/+181
|
* gui: forms editor - rules and excludes as forms, with add, delete and moveLukasz Kasprzak3 days3-3/+810
|
* gui: Rules tab - the file as text, checked as you type, tested and savedLukasz Kasprzak3 days2-1/+418
|
* gui: History and undo tab; each plan and undo is its own runLukasz Kasprzak3 days3-16/+460
|
* gui: row menu for trash or permanent delete; Apply frees the directoryLukasz Kasprzak3 days1-0/+95
|
* gui: the Plan tab - scan, review, apply, with the directory lockedLukasz Kasprzak3 days3-0/+506