aboutsummaryrefslogtreecommitdiff
path: root/internal/engine/apply.go
Commit message (Collapse)AuthorAgeFilesLines
* a chain that deletes itself still gives back the file it displacedLukasz Kasprzak2 days1-0/+61
| | | | | | | | | | | | | | | | | | | | | | | | (on-conflict overwrite) trashes the file in the way; §7.4 promises undo restores it. Walking a file's log entries stopped dead at a permanent delete, so the displace written earlier in the same chain was never reached: the user's file stayed in the Trash, the refusal named only the file they did not care about, and krino log called the run undone. The displaced file is a different file, so it is offered as its own entry in the undo plan, keyed by its own path - the deleted file stays refused, since nothing of it can come back, and the copy or move that preceded the delete stays unreversed too (undoing a copy whose original was then deleted would destroy the last remaining copy). The accounting matched: every reversible step of a deleted file was subtracted, its displace included, so the run read (undone). Only what genuinely cannot come back is subtracted now. End to end, the scenario from the review: the only copy of a file is displaced by an incoming one that is then permanently deleted. before: archive/ empty, "(undone)", nothing offered after: archive/a.pdf restored, run reads partly undone
* a file trashed to make room is logged the moment it is trashedLukasz Kasprzak2 days1-17/+23
| | | | | | | | | | | | | | | | | | | The displace was carried out first and logged only when the whole step finished - for a copy or a cross-device move, the entire data transfer later. A process killed in that window left the user's file in the Trash with nothing recording it: krino log said "nothing applied" and undo offered nothing. It is its own action with its own line (spec §9), so it is now written the moment trash.Put returns, through a hook ChainLogged calls before the step that needed the name begins. A displace that cannot be logged fails the step rather than compounding an unrecorded destructive act with a second one. Verified by killing krino -9 mid-copy with 600 MB in flight: before: krino log "nothing applied", 0 displace lines after: krino log "1 displaced", 1 displace line
* the module path is git.labunix.xyz/krinoLukasz Kasprzak2 days1-6/+6
| | | | | | | | | | | So that go install can find it. cgit serves no go-import meta tag, so nginx answers a ?go-get=1 request for /NAME with one pointing at https://git.labunix.xyz/NAME.git; the alternative was carrying a .git suffix through every import line forever. One sed over the imports, both go.mod files, and the dependency gate's whitelist. Nothing else depends on the path. go install works from the next tag, the first release whose go.mod carries it.
* comments that explain the code, not how it was writtenLukasz Kasprzak2 days1-175/+165
| | | | | | | | | | | | | | | | | | About 340 comments cited the development process: task and plan numbers, fix waves, rulings, reviewers, and the author in the third person with a date. None of that exists outside the work itself, so to a reader it pointed at nothing. Each one now states the engineering reason it was standing in front of; where a comment was provenance and nothing else, it is gone. References to docs/design.md and docs/gui-design.md by section stay: both ship with the repository. The design documents lose their amendment diaries - CHANGELOG.md is that record - and the GUI's says plainly that the window has gone further than the document. Only comments changed. Every .go file was parsed and its code printed with comments stripped, before and after: the two hashes are identical across all 175 files.
* gui: History and undo tab; each plan and undo is its own runLukasz Kasprzak4 days1-2/+12
|
* plan 10 re-check: cut run column, damaged undo run, emptied directory ↵v0.0.7Lukasz Kasprzak5 days1-1/+17
| | | | cleanup, text turning binary, explain flags, interrupt docs
* plan 10: an interrupt stops between steps; nohup keeps ignoring hangupsLukasz Kasprzak5 days1-3/+3
|
* plan 10: resumed undo re-checks what an earlier undo put back; occupied ↵Lukasz Kasprzak5 days1-2/+25
| | | | directory removals are not offered forever
* plan 10: a damaged log line refuses only its file, not the runLukasz Kasprzak5 days1-0/+8
|
* plan 10: a step that ran but could not be logged is named in the errorLukasz Kasprzak5 days1-1/+23
|
* plan 9: property test compares directories and refuses to pass vacuously; ↵Lukasz Kasprzak5 days1-2/+9
| | | | undo tracks directories trash restores recreate
* plan 9: an interrupted or failed undo can be finishedLukasz Kasprzak5 days1-2/+17
|
* plan 9: undo checks trash identity, groups by directory, re-checks at ↵Lukasz Kasprzak5 days1-28/+70
| | | | execution, removes directories it recreates
* plan 9: apply logs each step as it completes and stops a chain that landed ↵Lukasz Kasprzak5 days1-5/+7
| | | | elsewhere
* plan 8: generated apply and undo round trip; undo reverses chains within one ↵Lukasz Kasprzak5 days1-0/+9
| | | | file
* krino: release 0.0.1 — man pages, install, examples, cross and release, ↵v0.0.1Lukasz Kasprzak7 days1-0/+118
| | | | | | | | | README, changelog Also: undo removes the directories its run created; a hardlink is never a duplicate of its own other name; a flag written before "undo" is honoured; --version prints no leading v. Duplicate conditions with different scopes not sharing an original is documented as a known limitation.
* krino: acting — trash, journal, apply, lock, review, undoLukasz Kasprzak7 days1-0/+929