aboutsummaryrefslogtreecommitdiff
path: root/internal/journal/read_test.go
Commit message (Collapse)AuthorAgeFilesLines
* a chain that deletes itself still gives back the file it displacedLukasz Kasprzak48 hours1-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | (on-conflict overwrite) trashes the file in the way; §7.4 promises undo restores it. Walking a file's log entries stopped dead at a permanent delete, so the displace written earlier in the same chain was never reached: the user's file stayed in the Trash, the refusal named only the file they did not care about, and krino log called the run undone. The displaced file is a different file, so it is offered as its own entry in the undo plan, keyed by its own path - the deleted file stays refused, since nothing of it can come back, and the copy or move that preceded the delete stays unreversed too (undoing a copy whose original was then deleted would destroy the last remaining copy). The accounting matched: every reversible step of a deleted file was subtracted, its displace included, so the run read (undone). Only what genuinely cannot come back is subtracted now. End to end, the scenario from the review: the only copy of a file is displaced by an incoming one that is then permanently deleted. before: archive/ empty, "(undone)", nothing offered after: archive/a.pdf restored, run reads partly undone
* comments that explain the code, not how it was writtenLukasz Kasprzak2 days1-67/+65
| | | | | | | | | | | | | | | | | | About 340 comments cited the development process: task and plan numbers, fix waves, rulings, reviewers, and the author in the third person with a date. None of that exists outside the work itself, so to a reader it pointed at nothing. Each one now states the engineering reason it was standing in front of; where a comment was provenance and nothing else, it is gone. References to docs/design.md and docs/gui-design.md by section stay: both ship with the repository. The design documents lose their amendment diaries - CHANGELOG.md is that record - and the GUI's says plainly that the window has gone further than the document. Only comments changed. Every .go file was parsed and its code printed with comments stripped, before and after: the two hashes are identical across all 175 files.
* a permanently deleted file's steps do not keep a run partly undoneLukasz Kasprzak5 days1-0/+31
|
* krino log marks a run partly undone while reversible steps remainLukasz Kasprzak5 days1-0/+48
|
* plan 10 re-check: cut run column, damaged undo run, emptied directory ↵v0.0.7Lukasz Kasprzak5 days1-0/+29
| | | | cleanup, text turning binary, explain flags, interrupt docs
* plan 10: a damaged log line refuses only its file, not the runLukasz Kasprzak5 days1-15/+44
|
* plan 9: an interrupted or failed undo can be finishedLukasz Kasprzak5 days1-0/+48
|
* krino: release 0.0.1 — man pages, install, examples, cross and release, ↵v0.0.1Lukasz Kasprzak6 days1-0/+214
| | | | | | | | | README, changelog Also: undo removes the directories its run created; a hardlink is never a duplicate of its own other name; a flag written before "undo" is honoured; --version prints no leading v. Duplicate conditions with different scopes not sharing an original is documented as a known limitation.
* krino: acting — trash, journal, apply, lock, review, undoLukasz Kasprzak7 days1-0/+413