diff options
| author | Lukasz Kasprzak <lukas@labunix.xyz> | 2026-08-12 14:51:33 +0200 |
|---|---|---|
| committer | Lukasz Kasprzak <lukas@labunix.xyz> | 2026-08-12 14:51:33 +0200 |
| commit | 96b14d17e5210b93f1c126fe165fd81ec1e839af (patch) | |
| tree | 7382916de5a9415db6cc213fcfa6a03d4f9504ce /internal/calendar/temporal_test.go | |
| parent | 09a14446d5b0d4150a6de118a7d04ab99e54c21e (diff) | |
| download | lectio-96b14d17e5210b93f1c126fe165fd81ec1e839af.tar.gz lectio-96b14d17e5210b93f1c126fe165fd81ec1e839af.zip | |
oracle_ef_test: three structural coverage gaps in the strengthened test
Cheap fixes flagged in review, all confirmed against the committed
snapshot before being applied:
1. An unmapped season phrase skipped the RANK AND COLOUR checks too,
not just the season comparison -- `continue` in the wrong place.
Confirmed live: neither Holy Thursday ("maundy"/"holy week" do
not match the title "Holy Thursday" itself) nor any of the six
September Ember days (no "ember" case exists at all; the Advent
and Lent Ember days only ever passed by an incidental substring
match on "advent"/"lent") had any oracle coverage at all --
reverting the Holy Thursday colour fix left this test green.
Season skip and rank/colour checks are now independent.
2. Colour membership alone cannot catch a Rose regression: violet is
a member of every rose/violet pair by construction (Gaudete/
Laetare), so "got violet, want one of [rose violet]" passed even
with RG 131's Rose support removed entirely. On the day the pair
actually names (oracle rank 1, the Sunday itself, not a weekday
reusing its propers), a colour set containing rose now demands
rose specifically.
3. `has("sexagesima")` never matched missalemeum's own ligatured
"Sexagesimæ" -- confirmed in the committed snapshot: the ligatured
form appears 10 times, the unligatured form only 4, and every
ligatured instance mapped to season "" (skipped from ALL coverage,
not merely a season miss, given finding 1 above). Normalised once,
generally (æ -> ae), not as a single hardcoded word, so any other
ligature this generator's own data may carry is covered too.
Net effect on TestOracleEF: 730 checked (up from 691), 29 skipped
(down from 39) -- the 10 reclaimed by fix 3. Still green: 0
unallow-listed rank or colour mismatches over the full snapshot.
Diffstat (limited to 'internal/calendar/temporal_test.go')
0 files changed, 0 insertions, 0 deletions
